Re: [PATCH v15 1/2] dt-bindings: embedded-controller: Add synology microp devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string `synology,ds1221rpp-microp` is a typo for `synology,rs1221rpp-microp`.
--

commit 227a0e75c964c535a574ba2e91904deade287d1d
Author: Markus Probst <markus.probst@posteo.de>

dt-bindings: embedded-controller: Add synology microp devices

This commit adds the devicetree bindings for the Synology Microp
microcontroller. It documents the serial-connected controller used
for power, fan, and LED management across various Synology NAS models.

> diff --git a/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml
> new file mode 100644
> index 0000000000000..eb1c9d3fac074
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml

[ ... ]

> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - synology,ds1221rpp-microp

[Severity: Low]
Does this compatible string introduce an ABI regression due to a typo?

Synology hardware models with Redundant Power (RP+) are RackStations (RS),
not DiskStations (DS).

Should this compatible string in the properties.compatible enum be renamed
to synology,rs1221rpp-microp before it becomes a permanent part of the
kernel ABI?

> +              - synology,rs822p-microp
> +              - synology,rs422p-microp
> +          - const: synology,rs1221p-microp

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-synology_microp_initial-v15-0-4b3d7367c7cf@posteo.de?part=1