Re: [PATCH v6 3/4] arm64: dts: qcom: Add HONOR MagicBook Art 14 device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] DisplayPort over USB-C and HDMI are fundamentally broken due to invalid graph topology and missing SBU routing.
- [High] The touchpad interrupt pinmux configuration targets the wrong GPIO, breaking touchpad input.
- [High] The touchscreen reset pin lacks the `output-high` directive, leaving the device stuck in reset.
--

commit 3e10552e6c3c61e8d8f91d2bc36dc84459dad1e7
Author: Konstantin Shabanov <mail@etehtsea.me>

arm64: dts: qcom: Add HONOR MagicBook Art 14 device tree
    
Introduce support for the HONOR MagicBook Art 14 laptop.
This version is based on the initial work by Kirill A. Korinsky and
Valentin Manea.

Link: https://lore.kernel.org/all/871px910m1.wl-kirill@korins.ky/
Link: https://github.com/vamanea/linux-magicbook/blob/x1e80100-magicbook-6.19/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
Link: https://github.com/alsa-project/alsa-ucm-conf/pull/755

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts b/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts

[ ... ]

> +	pmic-glink {
> +		compatible = "qcom,x1e80100-pmic-glink",

[ ... ]

> +		connector@0 {
> +			compatible = "usb-c-connector";

[ ... ]

> +				port@1 {
> +					reg = <1>;
> +
> +					pmic_glink_ss0_ss_in: endpoint {
> +						remote-endpoint = <&usb_1_ss0_qmpphy_out>;
> +					};
> +				};
> +			};
> +		};

[Severity: High]
Are the port@2 definitions for routing SBU signals missing from both
connector@0 and connector@1? Without routing SBU lines to the hardware, Type-C
DisplayPort alternate mode negotiation might be unable to establish the
DP AUX channel.

[ ... ]

> +	i2c1 {
> +		clock-frequency = <400000>;
> +
> +		status = "okay";
> +
> +		touchpad@5d {
> +			compatible = "hid-over-i2c";
> +			reg = <0x5d>;
> +
> +			hid-descr-addr = <0x1>;
> +			interrupts-extended = <&tlmm 24 IRQ_TYPE_LEVEL_LOW>;

[ ... ]

> +	tlmm {
> +		gpio-reserved-ranges = <34 2>, /* Unused */
> +				       <44 4>; /* SPI (TPM) */
> +
> +		tpad_default: tpad-default-state {
> +			pins = "gpio3";
> +			function = "gpio";
> +			bias-disable;
> +		};

[Severity: High]
Is there a mismatch in the GPIO configuration for the touchpad? The node
declares the hardware interrupt on GPIO 24, but the tpad_default pinctrl
state configures GPIO 3. Will this prevent the system from receiving touchpad
events?

[ ... ]

> +	ts0_default: ts0-default-state {
> +		reset-n-pins {
> +			pins = "gpio48";
> +			function = "gpio";
> +			drive-strength = <16>;
> +		};
> +
> +		int-n-pins {

[Severity: High]
Does the touchscreen reset pin configuration need an output-high directive?
Since the hid-over-i2c driver does not actively manage a reset-gpios
property, omitting output-high here might leave the touchscreen stuck in
hardware reset.

[ ... ]

> +	usb_1_ss2_qmpphy {
> +		vdda-phy-supply = <&vreg_l2j_1p2>;
> +		vdda-pll-supply = <&vreg_l2d_0p9>;

[ ... ]

> +		ports {
> +			port@0 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				/delete-node/ endpoint;
> +
> +				usb_1_ss2_qmpphy_out_dp: endpoint@0 {
> +					reg = <0>;
> +
> +					data-lanes = <3 2 1 0>;
> +					remote-endpoint = <&hdmi_bridge_dp_in>;
> +				};
> +			};
> +		};
> +	};

[Severity: High]
Does replacing the QMP PHY's DP input endpoint with a connection to the HDMI
bridge's input sever the required connection from the GPU DP controller
(mdss_dp2_out)? Pointing port@0 away from the GPU might leave the HDMI
bridge without a valid signal source and break the GPU DP controller.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629154812.9066-1-mail@etehtsea.me?part=3