Re: [PATCH v16 1/2] dt-bindings: embedded-controller: Add synology microp devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `fan-failure-gpios` conditional block matches the specific leaf variant `synology,rs422p-microp` instead of its base fallback `synology,rs1221p-microp`, incorrectly forbidding the property for the rest of its hardware family.
--

commit ec0576fc5f2c12ad557bf63ad742921b02b47295
Author: Markus Probst <markus.probst@posteo.de>

dt-bindings: embedded-controller: Add synology microp devices

This commit adds the devicetree bindings for Synology Microp microcontrollers
used in Synology NAS devices. These controllers handle LEDs, fans, beepers,
buttons, and shutdown/reboot behaviors.

> diff --git a/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml
> new file mode 100644
> index 0000000000000..a441018843224
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - synology,ds918p-microp
> +              - synology,rs422p-microp

[Severity: Medium]
Does this conditional correctly cover the rs1221p hardware family?

The compatible block defines synology,rs1221p-microp as the fallback for
synology,rs422p-microp, synology,rs822p-microp, and
synology,rs1221rpp-microp. 

By matching against the specific leaf variant synology,rs422p-microp here
instead of the base fallback synology,rs1221p-microp, the else branch will
incorrectly forbid the fan-failure-gpios property for the rest of the
variants in this family, causing them to fail schema validation.

> +    then:
> +      required:
> +        - fan-failure-gpios
> +    else:
> +      properties:
> +        fan-failure-gpios: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-synology_microp_initial-v16-0-601e91c49e0d@posteo.de?part=1