From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EACDF326D55; Mon, 29 Jun 2026 19:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782763109; cv=none; b=V7+9Q2bN8QusJDpy1YotXmr4IDpRibo6fT6Liq6VGA4KSc0VUgs0yax1m7Wlmdi4JL/KDkMjTG8BjWQ9uC5B5Yt9bZ64CbU5uHXzk4dyPgBKytaGDxZkERWZ+1iXCC6OoTOWnZA4g2AR6nJkkSa2lPcRwqsv2v6Jneog8nsfuio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782763109; c=relaxed/simple; bh=Pr/4p417Yk+ccHUFysFdvgfkeFU/iwtNQqn2sEz9GwI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=uzIyzGZoFcRSxl06O/FdC3norUr2KhmNFmtnjlxwC55sWcQ3rzHV3xt9Nrfin16uheMmNg3XlCpz0E1aR0+cM6/dVo9qKKHJYa9SQtvn1AM6QAm2TJMdE2x6ObS+f2Z8v2BUvn4TfuUFZFmAtdtQhrWYbVkT1+RSh0db02VbfWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X+xyyRKZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X+xyyRKZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 308D81F000E9; Mon, 29 Jun 2026 19:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782763108; bh=iI9do+iageJ9x8NdPf8FlGva8q2GnSSKd09PZjSMCWI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=X+xyyRKZIRAZSMKe7OvrxaZjuZIbWejGrR3eHOZJPPROtNPFSnjSByo83WtUIEJW6 OiCV8GXRYWK47CQCZICZ8/mLb7p00scwXBdzLdQbO65uIVMQ8bBR/Bb7u0xyrtS7cS UloXyviSIZyhoakBchYfPya+EtEkZDH9W/Poq5jQf0LqqwiA0mLNTebAU2DFIhUBu2 L3qohVj4RNmkxkOi45e++bNr5/tGodixTs1vpDsdK1eV9LMjpNENC7/YE62VWpoPT8 EUEbb/EFvXtWfqGQkmgqHn5xnlw0jcXqUQpP/1GL7avESRDGLwLasH3ujn5sK6w5SZ 4CmWhSiY5yoKQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] arm64: dts: monaco-arduino-monza: microcontroller LEDs Reply-To: sashiko-reviews@lists.linux.dev To: "Loic Poulain" Cc: linux-leds@vger.kernel.org, lee@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260629-monza-leds-v1-3-0cf7c0a7dc14@oss.qualcomm.com> References: <20260629-monza-leds-v1-0-0cf7c0a7dc14@oss.qualcomm.com> <20260629-monza-leds-v1-3-0cf7c0a7dc14@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 29 Jun 2026 19:58:27 +0000 Message-Id: <20260629195828.308D81F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Device tree unit addresses for `led@10` and `led@11` are incorrectl= y formatted in decimal instead of hexadecimal. -- commit 21dc3bc44056192e48843a18f3858786db53ea22 Author: Loic Poulain arm64: dts: monaco-arduino-monza: microcontroller LEDs This commit adds a led controller compatible with PCA9635 to the Monaco Arduino Monza board. It configures four RGB LEDs controlled via channels 0-2, 3-5, 6-8, and 9-11. > diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm= 64/boot/dts/qcom/monaco-arduino-monza.dts > index 379b796f261f4..71685e54a3781 100644 > --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts > +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts [ ... ] > + multi-led@3 { > + reg =3D <3>; > + label =3D "stm-led-4"; > + color =3D ; > + function =3D LED_FUNCTION_STATUS; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + led@9 { > + reg =3D <9>; > + color =3D ; > + }; > + > + led@10 { > + reg =3D <10>; > + color =3D ; > + }; > + > + led@11 { [Severity: Low] This isn't a functional bug, but should the unit addresses for led@10 and l= ed@11 be formatted as lowercase hexadecimal (e.g. led@a and led@b) to match their= reg properties and avoid dtc unit_address_format warnings? > + reg =3D <11>; > + color =3D ; > + }; > + }; > + }; > +}; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629-monza-leds= -v1-0-0cf7c0a7dc14@oss.qualcomm.com?part=3D3