From: sashiko-bot@kernel.org
To: "Nathan Morrisson" <nmorrisson@phytec.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 2/2] arm64: dts: ti: Add support for the phyCORE-AM67x
Date: Mon, 29 Jun 2026 22:42:52 +0000 [thread overview]
Message-ID: <20260629224253.12D2D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260629223353.1495209-2-nmorrisson@phytec.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The ASoC `simple-audio-card,routing` array contains reversed routes for the physical speakers, mapping the codec outputs as sinks and the speakers as sources.
--
commit 9dfefe3748ffabcd91be3c99b1fecce0ae98ac5f
Author: Nathan Morrisson <nmorrisson@phytec.com>
arm64: dts: ti: Add support for the phyCORE-AM67x
This commit adds support for the PHYTEC phyCORE-AM67x SoM and the
corresponding phyBOARD-Rigel carrier board. It enables various features
including audio playback, Ethernet, CAN, and eMMC.
Link: https://www.phytec.com/product/phycore-am67x/
Link: https://www.phytec.com/product/phyboard-am67x-development-kit/
> diff --git a/arch/arm64/boot/dts/ti/k3-am6754-phyboard-rigel.dts b/arch/arm64/boot/dts/ti/k3-am6754-phyboard-rigel.dts
> new file mode 100644
> index 0000000000000..26dcda26061f9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am6754-phyboard-rigel.dts
[ ... ]
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,widgets =
> + "Microphone", "Mic Jack",
> + "Headphone", "Headphone Jack",
> + "Line", "Stereo Jack",
> + "Speaker", "L SPKR",
> + "Speaker", "R SPKR";
> + simple-audio-card,routing =
> + "MIC1RP", "Mic Jack",
> + "Mic Jack", "MICBIAS",
> + "Headphone Jack", "HPL",
> + "Headphone Jack", "HPR",
> + "MIC1LM", "Stereo Jack",
> + "MIC1LP", "Stereo Jack",
> + "SPL", "L SPKR",
> + "SPR", "R SPKR";
[Severity: Medium]
Are the routing endpoints for the physical speakers reversed here?
The simple-audio-card,routing property uses the syntax "sink", "source".
By defining "SPL", "L SPKR", the codec output pin SPL is treated as a sink
and the physical speaker L SPKR is treated as a source.
Because the speaker widget is an endpoint with no outputs and the codec
output pin has no inputs, DAPM cannot build a valid audio path. This will
cause the speaker audio path to fail to initialize.
Should these be defined as "L SPKR", "SPL" and "R SPKR", "SPR" instead?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260629223353.1495209-1-nmorrisson@phytec.com?part=2
prev parent reply other threads:[~2026-06-29 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 22:33 [PATCH v3 1/2] dt-bindings: arm: ti: Add bindings for PHYTEC AM67x based hardware Nathan Morrisson
2026-06-29 22:33 ` [PATCH v3 2/2] arm64: dts: ti: Add support for the phyCORE-AM67x Nathan Morrisson
2026-06-29 22:42 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629224253.12D2D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=nmorrisson@phytec.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox