From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] spi: dt-bindings: snps,dw-apb-ssi: drop superfluous RZ/N1 entry
Date: Tue, 30 Jun 2026 08:47:45 +0200 [thread overview]
Message-ID: <20260630-dazzling-intrepid-lobster-c83db6@quoll> (raw)
In-Reply-To: <20260626180326.9593-2-wsa+renesas@sang-engineering.com>
On Fri, Jun 26, 2026 at 08:03:22PM +0200, Wolfram Sang wrote:
> Commit 164c05f03ffa ("spi: Convert DW SPI binding to DT schema") added
> an RZ/N1 entry which was not in the original txt-file. It doesn't follow
> the usual "<soc entry>, <soc family entry>" style for Renesas SoCs which
> was properly added later with commit 029d32a892a8 ("spi: dw-apb-ssi:
Does not matter really. It was added apparently to match the compatibles
used.
> Integrate Renesas RZ/N1 SPI controller"). In that commit, removing the
> bogus entry was overlooked and is finally done now.
You introduce undocumented ABI or your patchset is non-bisectable. Past
commit is past history, so not really a reason to introduce new errors
(and undocumented ABI is considered such).
Please drop the patch or fix it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-30 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 18:03 [PATCH v4 0/4] ARM: dts: renesas: r9a06g032-rzn1d400-eb: Enable SPI and FRAM Wolfram Sang
2026-06-26 18:03 ` [PATCH v4 1/4] spi: dt-bindings: snps,dw-apb-ssi: drop superfluous RZ/N1 entry Wolfram Sang
2026-06-29 9:32 ` Geert Uytterhoeven
2026-06-30 6:47 ` Krzysztof Kozlowski [this message]
2026-06-30 6:50 ` Krzysztof Kozlowski
2026-07-01 11:16 ` Wolfram Sang
2026-06-26 18:03 ` [PATCH v4 2/4] spi: dt-bindings: snps,dw-apb-ssi: add 'power-domains' property Wolfram Sang
2026-06-30 6:50 ` Krzysztof Kozlowski
2026-06-30 15:41 ` Geert Uytterhoeven
2026-06-26 18:03 ` [PATCH v4 3/4] ARM: dts: renesas: r9a06g032: Describe SPI controllers Wolfram Sang
2026-06-29 13:23 ` Geert Uytterhoeven
2026-06-26 18:03 ` [PATCH v4 4/4] ARM: dts: renesas: r9a06g032-rzn1d400-eb: Enable SPI-FRAM Wolfram Sang
2026-06-29 13:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630-dazzling-intrepid-lobster-c83db6@quoll \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox