Re: [PATCH v5 3/3] arm64: dts: nuvoton: Add I2C nodes for MA35D1 SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree node for the NAU8822 audio codec uses a model-specific name rather than a generic functional name.
--

commit 4b9e8074772f80384175f231ae4886c8f9599142
Author: Zi-Yu Chen <zychennvt@gmail.com>

arm64: dts: nuvoton: Add I2C nodes for MA35D1 SoC

Add I2C controller nodes to the MA35D1 SoC dtsi file. Also, enable the I2C2
interface on the MA35D1 SOM board and configure its pinctrl to allow
communication with the onboard NAU8822 audio codec.

> diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1-som-256m.dts b/arch/arm64/boot/dts/nuvoton/ma35d1-som-256m.dts
> index f6f20a17e5018..4b9ff6d006314 100644
> --- a/arch/arm64/boot/dts/nuvoton/ma35d1-som-256m.dts
> +++ b/arch/arm64/boot/dts/nuvoton/ma35d1-som-256m.dts
> @@ -55,6 +55,18 @@ &clk {
>  			   "integer";
>  };
>  
> +&i2c2 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +
> +	nau8822: nau8822@1a {

[Severity: Low]
This isn't a bug, but should this devicetree node use a generic functional name
like audio-codec@1a instead of the model-specific nau8822@1a?

The Devicetree Specification (Section 2.2.2 Generic Names Recommendation)
requires node names to describe the general class of device, and using specific
names can lead to dt-schema validation warnings.

> +		compatible = "nuvoton,nau8822";
> +		reg = <0x1a> ;
> +		nuvoton,spk-btl;
> +	};
> +};
> +

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630012106.3616821-1-zychennvt@gmail.com?part=3