From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97E6D1F91D6; Tue, 30 Jun 2026 00:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782780204; cv=none; b=DFJVqdLjKy6LVq9jKmZYE7357tMLU18VVldtZgxIxopVTDNE6KJ7N184mpIQHeYtPkDIbgyYVst6gLqDozkDgE2rnh+F8jkx+LyHJcgMh1UQjyT/ZPs0kD7lAV6aRIry4oR3YpZ4Yu2PqBiRBBSbuGhv35pKKYwprvzQMVKG9RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782780204; c=relaxed/simple; bh=XCYsMANmwLrcDRBWlr3mUwE65kXSuP4yPX5Dzw0XCtU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AD2quNJGi948h2zL9+/+JzVWNbocNpjKdVlBVQyN2sNicJFYmsz3/8BFH+4EGZjTgpSdNMxo0/ioFZTW1BKxoLtxhnzKL1TYhQQguHar+v2DbF97lgDi5LumN1wVOt/0XjYprn+NVCE3Y7/AI7X/C1Tr5tEGlFSmmreGXg7qrY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X1GDfHGj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X1GDfHGj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 773751F000E9; Tue, 30 Jun 2026 00:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782780203; bh=97Oc1JTmobiYknnZhsJ0eH2BXLzDou+75U1Rf+FMpAE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=X1GDfHGjp04WeJunf8T/yOgT1HrSrFniwXyA/xZYKzpRuYGpOD6Kf/Kouo4Ilcsrh nLUNnqb4Z59lqUNsr7Uh6HYCJ40Feovhb4mbtqTN56L2km8BNMFECnouAqA9VJisNw FwfuiaZrT/YXBFLG8zaWHPVWWnCgu7h2WYeHtLjGP7S78MDmeZ5JI01vYWL23aUEWz EBEeOFO+ZeasIjPQSjHQn221mEAwUtgAjnah/6hFR2tyRJOsIM+AqUGnMQDXUjWW7P M2QVWwb84Cmv0TK/sajCArXMYrBHwE6Ar6wdkZJu+MkVfdPx7TVHMfTQNP8EZ5ixQM 6PvsiPRFhUYWQ== Date: Tue, 30 Jun 2026 01:43:18 +0100 From: Jonathan Cameron To: Kurt Borja Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] iio: adc: Add ti-ads1262 driver Message-ID: <20260630014318.634af343@jic23-huawei> In-Reply-To: <20260628-ads126x-v2-2-4b1b231325ba@gmail.com> References: <20260628-ads126x-v2-0-4b1b231325ba@gmail.com> <20260628-ads126x-v2-2-4b1b231325ba@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 28 Jun 2026 00:36:03 -0500 Kurt Borja wrote: > Add the ti-ads1262 driver with initial support for the primary ADC > (ADC1). The ADS1263 auxiliary ADC (ADC2) is handled by a separate driver > and interoperability considerations were taken into account. > > Signed-off-by: Kurt Borja I took a quick look and vast majority of stuff I found was already well covered by David. I'll take a more detailed look at next version. One trivial thing inline. Thanks, Jonathan > diff --git a/drivers/iio/adc/ti-ads1262.c b/drivers/iio/adc/ti-ads1262.c > new file mode 100644 > index 0000000000000000..6103cf5a2d1624a9 > --- /dev/null > +++ b/drivers/iio/adc/ti-ads1262.c > +static int ads1262_write_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, int val, > + int val2, long mask) > +{ > + struct ads1262 *st = iio_priv(indio_dev); > + struct ads1262_channel *chan_data; > + int i; > + > + chan_data = &st->channels[chan->scan_index]; > + > + switch (mask) { > + case IIO_CHAN_INFO_SAMP_FREQ: { > + i = ads1262_find_two(ads1262_data_rate_avail, val, val2); > + if (i < 0) > + return i; > + > + guard(mutex)(&st->chan_lock); > + chan_data->data_rate = i; > + > + break; Trivial but might as well return 0 here and save a reader going to look for what else happens after the switch. > + } > + > + case IIO_CHAN_INFO_HARDWAREGAIN: { > + i = ads1262_find_one(ads1262_pga_gain_avail, val); > + if (i < 0) > + return i; > + > + guard(mutex)(&st->chan_lock); > + chan_data->gain = i; > + > + break; > + } > + > + default: > + return -EOPNOTSUPP; > + } > + > + return 0; > +}