Re: [PATCH v5 2/2] clk: amlogic: Add A9 peripherals clock controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Kconfig symbol COMMON_CLK_A9_PERIPHERALS implies the non-existent symbol COMMON_CLK_A9_PLL.
--

commit 4ac705194c44e52e50be696d549cd67fcfe58042
Author: Jian Hu <jian.hu@amlogic.com>

clk: amlogic: Add A9 peripherals clock controller driver

This commit adds the peripherals clock controller driver for the Amlogic
A9 SoC family.

> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -132,6 +132,21 @@ config COMMON_CLK_A1_PERIPHERALS
>  	  device, A1 SoC Family. Say Y if you want A1 Peripherals clock
>  	  controller to work.
>  
> +config COMMON_CLK_A9_PERIPHERALS
> +	tristate "Amlogic A9 SoC peripherals clock controller support"
> +	depends on ARM64 || COMPILE_TEST
> +	default ARCH_MESON
> +	select COMMON_CLK_MESON_REGMAP
> +	select COMMON_CLK_MESON_CLKC_UTILS
> +	select COMMON_CLK_MESON_DUALDIV
> +	select COMMON_CLK_MESON_VID_PLL_DIV
> +	imply COMMON_CLK_SCMI
> +	imply COMMON_CLK_A9_PLL

[Severity: Medium]
Does the config symbol COMMON_CLK_A9_PLL exist in the kernel tree? 
Referencing a non-existent symbol in an imply statement will silently fail
to pull in the expected dependency during configuration. Is it possible this
config was missing from the patch series, or is this a typo?

> +	help
> +	  Support for the peripherals clock controller on Amlogic A311Y3 based
> +	  device, AKA A9. Peripherals are required by most peripheral to operate.
> +	  Say Y if you want A9 peripherals clock controller to work.
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630-a9_peripherals-v5-0-bc4019730354@amlogic.com?part=2