Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Xu Yang" <xu.yang_2@oss.nxp.com>
Cc: Frank.Li@kernel.org, conor+dt@kernel.org, robh@kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v3 3/4] arm64: dts: imx95: switch usb3 controller to flattened model
Date: Tue, 30 Jun 2026 11:03:43 +0000	[thread overview]
Message-ID: <20260630110343.E9F501F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260630103629.76604-3-xu.yang_2@oss.nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added wrapper node `bus@4c100000` contains a unit address but lacks a `reg` property, violating the Devicetree Specification and triggering a DTC warning.
--

commit a2bcbb6922581174c083a123854fd752994b591f
Author: Xu Yang <xu.yang_2@nxp.com>

arm64: dts: imx95: switch usb3 controller to flattened model

This commit switches the USB3 controller to use a flattened model. It adds
a simple-bus wrapper to constrain the DMA address range so the controller
can access memory correctly.

> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 71394871d8dd0..80f935af5b49c 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
[ ... ]
> @@ -1772,45 +1772,45 @@ smmu: iommu@490d0000 {
[ ... ]
> +		bus@4c100000 {
> +			compatible = "simple-bus";
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> -			ranges;
> -			power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
>  			dma-ranges = <0x0 0x0 0x0 0x0 0x10 0x0>;
> -			status = "disabled";
> +			ranges;

[Severity: Low]
Does this new wrapper node trigger a DTC unit_address_vs_reg warning?

Because the node has a unit address (@4c100000) but lacks a reg property,
it violates the devicetree specification. Empty ranges properties are
ignored by DTC for this check, which will result in a build warning when
compiling with W=1.

>  
> -			usb3_dwc3: usb@4c100000 {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630103629.76604-1-xu.yang_2@oss.nxp.com?part=3

  reply	other threads:[~2026-06-30 11:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 10:36 [PATCH v3 1/4] arm64: dts: imx8mp-evk: add typec node Xu Yang
2026-06-30 10:36 ` [PATCH v3 2/4] arm64: dts: imx8mp-evk: add usb3_phy1 tuning properties Xu Yang
2026-06-30 10:36 ` [PATCH v3 3/4] arm64: dts: imx95: switch usb3 controller to flattened model Xu Yang
2026-06-30 11:03   ` sashiko-bot [this message]
2026-06-30 10:36 ` [PATCH v3 4/4] arm64: dts: imx8mq-evk: add typec node Xu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630110343.E9F501F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xu.yang_2@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox