Re: [PATCH v2 5/6] arm64: dts: qcom: ipq5018: add nodes required for Bluetooth support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding "syscon" to the apcs_glb compatible string violates the current DT binding schema and will cause a dtbs_check failure.
--

commit 8d5a37566d441600f3735791890dcc06ffb70e79
Author: George Moussalem <george.moussalem@outlook.com>

arm64: dts: qcom: ipq5018: add nodes required for Bluetooth support
    
This commit adds device tree nodes for the reserved memory carveout and
Bluetooth on the IPQ5018 platform. It also modifies the apcs_glb mailbox
node to include the syscon compatible string.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index 6f8004a22a1ff..65a47ba7d3a34 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi

[ ... ]

> @@ -647,7 +669,8 @@ watchdog: watchdog@b017000 {
>  
>  		apcs_glb: mailbox@b111000 {
>  			compatible = "qcom,ipq5018-apcs-apps-global",
> -				     "qcom,ipq6018-apcs-apps-global";
> +				     "qcom,ipq6018-apcs-apps-global",
> +				     "syscon";

[Severity: Low]
Does adding "syscon" here without updating the device tree bindings schema
cause dtbs_check to fail?

The schema in Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
strictly limits the compatible array for qcom,ipq5018-apcs-apps-global to
exactly two items. Will the validation fail when parsing this new item?

Should the DT binding schema be updated in a companion patch to permit the
"syscon" compatible string for this node?

>  			reg = <0x0b111000 0x1000>;
>  			#clock-cells = <1>;
>  			clocks = <&a53pll>, <&xo_board_clk>, <&gcc GPLL0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-ipq5018-bluetooth-v2-0-02770f03b6bb@outlook.com?part=5