From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4105C3DBD44 for ; Tue, 30 Jun 2026 17:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782840243; cv=none; b=lURLK0bH1vUuIWM6gmYNWVlpIXzyKGWrK/D0n+UetZexFnseku41ILiyT4KZ3ZTcXtT2s5i2RQYHT4C0UAA+uAXEbTHmCDNnwwlQeytFHcuXTwpb8f5ku2mqwnybO1ZmpM9/lOK13Gs9l+MKVBuSttjra6F4CWW5/QaKApB1OA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782840243; c=relaxed/simple; bh=L1+URms1HeQEH1fMM/xYxvnqMT6fGIph1XX8xsI+fMY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=uTmIPTTvLoulDCE+XAGo3WE9/62+c7a1a+UiS9wlpkMlMm2gsQ3wwaLxt2kjLr+WwFNCbOxzuAlw7ZfDCf3wMFHomgfN5Zg0+nCJuJF6pbk35my1SxWCJZF60HH3GxQSmfisJv98nP/cnhNrOcqz+DQmWhAdSend6ZZCOhEaWyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XoWnQahX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XoWnQahX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6BA11F000E9; Tue, 30 Jun 2026 17:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782840241; bh=FdAQo2h4vU+MdU1+MmxV7DhVuEUi6q4VJCjdkPgK3UU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=XoWnQahXif+UXguAsyGg2snmnnxnB4cqGMCAYutcGA+V5Og9KDr5iv/qBAI9Azx9P 1VQH/aVhtS6G6ePAYF35CLkvRAly9WZHLzJ8et5JJWZO3YcGadBDDtkuFJ+JRNeJJq EFDkHmX6f+i/PYaNltaooJB4rPrF1yrqq/4lY9DETayeN88O0yIVmV425sW7BmjH8l qM6dhU/CM7Rrt3QeSA318mfy8B3/nXntQA4PvAqgGizGSas3kSuKwl8Q9720EI+LeH 8kuzD3HaZ4foC8KumRwK2iDu2l0ZTtHziD/svXahlbGP6eIEFGzJ0sVR8vdFMfHVQK WAkx+c0UHlZvw== From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v6 03/15] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory Reply-To: sashiko-reviews@lists.linux.dev To: "Selvamani Rajagopal via B4 Relay" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260629-s2500-mac-phy-support-v6-3-18ce79500371@onsemi.com> References: <20260629-s2500-mac-phy-support-v6-0-18ce79500371@onsemi.com> <20260629-s2500-mac-phy-support-v6-3-18ce79500371@onsemi.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 30 Jun 2026 17:24:01 +0000 Message-Id: <20260630172401.B6BA11F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Medium] Kernel module rename from `oa_tc6.ko` to `oa_tc6_mod.ko` breaks = ABI. - [Low] Unintended removal of the 'if COMPILE_TEST' condition from the Kcon= fig prompt. - [Low] MAINTAINERS entry update uses a restrictive wildcard pattern that o= rphans the directory's Makefile and Kconfig. -- commit 17abade4ed4c6f154b7b7813c44e60fe8fc7040d Author: Selvamani Rajagopal net: ethernet: oa_tc6: Move oa_tc6.c to its own directory This commit moves oa_tc6.c to a new drivers/net/ethernet/oa_tc6 directory. It updates Kconfig, Makefile, and MAINTAINERS to support adding future files for hardware timestamp and PTP related APIs. > diff --git a/MAINTAINERS b/MAINTAINERS > index 15011f5752a99..ff1295d37ae21 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20217,7 +20217,7 @@ M: Parthiban Veerasooran > L: netdev@vger.kernel.org > S: Maintained > F: Documentation/networking/oa-tc6-framework.rst > -F: drivers/net/ethernet/oa_tc6.c > +F: drivers/net/ethernet/oa_tc6/oa_tc6* [Severity: Low] Does this restrictive wildcard pattern orphan the new Makefile and Kconfig files? Since it only matches files starting with oa_tc6, patches modifying those build files might not automatically CC the maintainers via get_maintainer.p= l. [ ... ] > diff --git a/drivers/net/ethernet/oa_tc6/Kconfig b/drivers/net/ethernet/o= a_tc6/Kconfig > new file mode 100644 > index 0000000000000..97345f345fb9f > --- /dev/null > +++ b/drivers/net/ethernet/oa_tc6/Kconfig > @@ -0,0 +1,16 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# OA TC6 10BASE-T1x MAC-PHY configuration > +# > + > +config OA_TC6 > + tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support" [Severity: Low] Was it intentional to drop the if COMPILE_TEST condition from the tristate prompt here? The original config in drivers/net/ethernet/Kconfig had=20 tristate "..." if COMPILE_TEST, which kept the prompt hidden unless COMPILE_TEST was enabled. Dropping it exposes the prompt to any user with SPI enabled. > + depends on SPI > + select PHYLIB [ ... ] > diff --git a/drivers/net/ethernet/oa_tc6/Makefile b/drivers/net/ethernet/= oa_tc6/Makefile > new file mode 100644 > index 0000000000000..f24aae852ef27 > --- /dev/null > +++ b/drivers/net/ethernet/oa_tc6/Makefile > @@ -0,0 +1,7 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Makefile for OA TC6 10BASE-T1x MAC-PHY > +# > + > +obj-$(CONFIG_OA_TC6) :=3D oa_tc6_mod.o > +oa_tc6_mod-objs :=3D oa_tc6.o [Severity: Medium] Does this change break userspace ABI by implicitly renaming the compiled module from oa_tc6.ko to oa_tc6_mod.ko? Modifying the module name can break external scripts, modprobe configuratio= ns, and initramfs expectations that rely on the old name. To fix Kbuild circular dependency warnings while keeping the original module name, should the C file be renamed instead (e.g., to oa_tc6_core.c) while keeping obj-$(CONFIG_OA_TC6) +=3D oa_tc6.o? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260629-s2500-mac-= phy-support-v6-0-18ce79500371@onsemi.com?part=3D3