From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D63823DE451; Tue, 30 Jun 2026 17:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782841400; cv=none; b=NdhEDZvglRbqIUCHPqe8MD1Qm8qo9fiZbk7+G2Dmb/DtyGxTarqS1cKfnuUaFLfzIqWraANXyeGQHxL7Iroasc1q6McmqVucAdMSNn4R8i4s/SN1xnnS7BYfBdIjZeA/tMuRJEUeeAUfkmLee2wL/ZDYd5kUIaodlomI9wUwYgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782841400; c=relaxed/simple; bh=4bME/lFWu03KnccIT78SQlKlqTHUi2zHDGnJOGODiv0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=rk5knAvUtiYzjpZ7Wf97HumV/pboPXVVLe6QFFWWOUZ+UXHDIyM9LcFUV+xZ/CGDC/3PSdGUpC/iRTh/cHZYa11M+ubWdlo4z2WALA8GdMnOqPeixetecrqnhbqFJDWfgreT1Xdtypa07xAjpFP1EFJmrCPNw2GDdIxfVd26ZbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gOFLfW1D; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gOFLfW1D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E9321F00A3A; Tue, 30 Jun 2026 17:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782841397; bh=S3iXaxGaxT2dySeFVOF2DWE5gKOSoGbd0S/9p13lfiE=; h=Date:From:To:Cc:Subject:In-Reply-To; b=gOFLfW1DzKuL4/zlQfn4onCyUuXVpktPNdtadshp8G1pFpnQMG7D3o7ViZK8+lScO TEs6YfC6jM77MewJww0XCCw9syRBHs0zH3bcbPY8zi9DYXBouWKG7HWQ3IYnOu4F+K jIGFUUttvihSV6RugIDs9aPsvH3Nw+2UWEYf6L4JJzMDeHuMK7d4WwnIT3DXKjZVtq 8k0LFdMAUmWDR26QPCafsRnlERdpPsm4rcrt84rVMYwLWgck/Mryz679ch8r/b29H2 BwAzXwbJr5AmLAgqoF9XW65nmWg+68WmguWP8KX7zf9OQCnzCiQHW1ZzJRiANn8hXZ Mh5d1kelM4GtA== Date: Tue, 30 Jun 2026 12:43:16 -0500 From: Bjorn Helgaas To: "Sherry Sun (OSS)" Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org, imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, sherry.sun@nxp.com, Ryder Lee , linux-mediatek@lists.infradead.org Subject: Re: [PATCH V4 2/8] PCI: imx6: Add skip_pwrctrl_off flag support Message-ID: <20260630174316.GA162203@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630103139.3823329-3-sherry.sun@oss.nxp.com> [+cc Mediatek folks] On Tue, Jun 30, 2026 at 06:31:33PM +0800, Sherry Sun (OSS) wrote: > From: Sherry Sun > > Use dw_pcie_rp::skip_pwrctrl_off to avoid powering off devices during > suspend to preserve wakeup capability of the devices and also not to power > on the devices in the init path. Only pci-imx6.c, pcie-qcom.c, and pcie-mediatek-gen3.c use pci-pwrctrl. pcie-qcom.c already has similar skip_pwrctrl_off checks, but pcie-mediatek-gen3.c does not. Does it need them? > This allows controller power-off to be skipped when some devices(e.g. M.2 > cards key E without auxiliary power) required to support PCIe L2 link state > and wake-up mechanisms. > > Signed-off-by: Sherry Sun > --- > drivers/pci/controller/dwc/pci-imx6.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 1b535bb6fd31..0685573fee71 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1382,10 +1382,12 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) > } > } > > - ret = pci_pwrctrl_power_on_devices(dev); > - if (ret) { > - dev_err(dev, "failed to power on pwrctrl devices\n"); > - goto err_reg_disable; > + if (!pp->skip_pwrctrl_off) { > + ret = pci_pwrctrl_power_on_devices(dev); > + if (ret) { > + dev_err(dev, "failed to power on pwrctrl devices\n"); > + goto err_reg_disable; > + } > } > > ret = imx_pcie_clk_enable(imx_pcie); > @@ -1454,7 +1456,8 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) > err_clk_disable: > imx_pcie_clk_disable(imx_pcie); > err_pwrctrl_power_off: > - pci_pwrctrl_power_off_devices(dev); > + if (!pp->skip_pwrctrl_off) > + pci_pwrctrl_power_off_devices(dev); > err_reg_disable: > if (imx_pcie->vpcie) > regulator_disable(imx_pcie->vpcie); > @@ -1473,7 +1476,8 @@ static void imx_pcie_host_exit(struct dw_pcie_rp *pp) > } > imx_pcie_clk_disable(imx_pcie); > > - pci_pwrctrl_power_off_devices(pci->dev); > + if (!pci->pp.skip_pwrctrl_off) > + pci_pwrctrl_power_off_devices(pci->dev); > if (imx_pcie->vpcie) > regulator_disable(imx_pcie->vpcie); > } > @@ -1990,11 +1994,14 @@ static int imx_pcie_probe(struct platform_device *pdev) > static void imx_pcie_shutdown(struct platform_device *pdev) > { > struct imx_pcie *imx_pcie = platform_get_drvdata(pdev); > + struct dw_pcie *pci = imx_pcie->pci; > + struct dw_pcie_rp *pp = &pci->pp; > > /* bring down link, so bootloader gets clean state in case of reboot */ > imx_pcie_assert_core_reset(imx_pcie); > imx_pcie_assert_perst(imx_pcie, true); > - pci_pwrctrl_power_off_devices(&pdev->dev); > + if (!pp->skip_pwrctrl_off) > + pci_pwrctrl_power_off_devices(&pdev->dev); > pci_pwrctrl_destroy_devices(&pdev->dev); > } > > -- > 2.50.1 >