From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E299A202F71; Tue, 30 Jun 2026 19:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782847832; cv=none; b=bB+4ihwdYhnrlrU3s1FiXMJhXMfUleKuWieovxrDnjzmub+qIqVxaeSSfqp67aG6aP6n4UqPXbMFCZ2Fn5UQR8VKGEzWp6tcJ8EgEfOPiajyOcdI9qNk7YxveeHEG1tMjVsXcgcbk+iGjb/H+zRXAhriPDvqI+lxk+XSZZhU6Y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782847832; c=relaxed/simple; bh=pVwxjc4k12YI/GvQufu+3Nu5mliK1CVmuGrEGYCs7lI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ecbHgXKYX2mUNnL+NJi/OKzksCmiPTSPgUvg3yBhMTYWx6rYAIyAZETqiC47rgFhDfzhWXrwU6mLJ07BaTWfXrFR/NbQG+SXUFuLu27UsJJn8aq8EUitjy+8C/pw3ckIfznell5G5Bxf3VrkuDyRAwgrh55dcTjztO4fYikdl8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V6wBAcSx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V6wBAcSx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 471AB1F00A3A; Tue, 30 Jun 2026 19:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782847831; bh=APVqnV/9U1mbZyK4JxBintbbRuaK/ninax4qiLIaDaM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V6wBAcSxMjCcQUTpV0+1RF78g7e0dRSINMd/QmYE39/6yWWNhzRZD0bGiRTmzXsmQ rha7rcG0/vLdScyJil9M7LS4dUtnFi8IqWtg4HROorYZtTeeYr/8fu3x062PhPW7jq 6HJ/mNDzh8J3iWVvUqpcRFQn0rPOCq2NTNwQcT4r77LVr4kaNa0iapFXq0OA2zK3ED B1foSSlWjissIAePqgCiVfgtCmc+VuMO4qgWfx7Zv4bnX6wc+youiMe+f0cSS6+w7/ YfLBcKIePvgWLW4tQELwdX81HtFbcYx77fgEv55tMrz1Swvy/VsmXl+WEzQLW6JyPe 7h0SvAjr8xTFQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add sii,wakealarm-output-pin property for S35390A Reply-To: sashiko-reviews@lists.linux.dev To: "Markus Probst" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, "Alexandre Belloni" In-Reply-To: <20260630-rtc_s35390a_int1-v1-1-1b2239e16be2@posteo.de> References: <20260630-rtc_s35390a_int1-v1-0-1b2239e16be2@posteo.de> <20260630-rtc_s35390a_int1-v1-1-1b2239e16be2@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 30 Jun 2026 19:30:30 +0000 Message-Id: <20260630193031.471AB1F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The newly extracted `sii,s35390a.yaml` binding omits the `interrupt= s` property definition, causing device trees that wire the RTC's interrupt = to fail schema validation. -- commit da1782a5913222ef5662be378a08ff2b2b0c13fa Author: Markus Probst dt-bindings: rtc: Add sii,wakealarm-output-pin property for S35390A Synology NAS devices use the output pin for interrupt signal 1 to wake up the system. This commit moves the devicetree bindings for sii,s35390a into its own file and adds the sii,wakealarm-output-pin property to configure the alarm. > diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Doc= umentation/devicetree/bindings/rtc/sii,s35390a.yaml > new file mode 100644 > index 0000000000000..31a5786738700 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml [ ... ] > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + const: sii,s35390a > + > + reg: > + maxItems: 1 [Severity: Low] Does moving this binding out of trivial-rtc.yaml and setting unevaluatedProperties to false without defining the interrupts property break schema validation for existing device trees? Previously, the interrupts property was allowed when the compatible string resided in trivial-rtc.yaml. Without an interrupts property definition here, device trees that wire the RTC's interrupt will fail dt_binding_check. Should the interrupts property be explicitly added to this properties block? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260630-rtc_s35390= a_int1-v1-0-1b2239e16be2@posteo.de?part=3D1