Re: [PATCH v2 2/4] dt-bindings: raspberrypi,bcm2835-firmware: Include 'reboot-mode.yaml'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The DT schema inadvertently rejects generic reboot mode properties due to the retention of `additionalProperties: false` alongside a `$ref` in `allOf`, contradicting the stated intent.
--

commit f839a4f18593a7083b268a49226464a9e0f0e8b5
Author: Gregor Herburger <gregor.herburger@linutronix.de>

dt-bindings: raspberrypi,bcm2835-firmware: Include 'reboot-mode.yaml'

This commit allows reboot mode properties by referencing the
reboot-mode.yaml schema for the Raspberry Pi firmware. It restricts the
maxItems to 1 for specific modes because the firmware accepts a 32-bit
reboot flag.

> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index 983ea80eaec97..28c5713860468 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
[ ... ]
> @@ -133,6 +133,15 @@ properties:
>      required:
>        - compatible
>  
> +  mode-normal:
> +    maxItems: 1
> +
> +  mode-tryboot:
> +    maxItems: 1
> +
> +allOf:
> +  - $ref: /schemas/power/reset/reboot-mode.yaml#
> +

[Severity: Medium]
Will this schema inadvertently reject generic reboot mode properties due to
the retention of additionalProperties: false later in the file?

Because additionalProperties: false is used instead of
unevaluatedProperties: false, properties defined in the referenced
reboot-mode.yaml schema but omitted here are rejected. This prevents device
trees from using other standard reboot modes like mode-recovery or
mode-bootloader.

Could the mode-normal and mode-tryboot properties be replaced with a single
patternProperties rule for ^mode-.*$ to enforce the 32-bit cell restriction
across all reboot modes, while changing the schema to use
unevaluatedProperties: false?

>  required:
>    - compatible
>    - mboxes

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630-rpi-tryboot-v2-0-f68d2dc6aa27@linutronix.de?part=2