Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
	 krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document HAMOA-IOT-COME board
Date: Wed, 1 Jul 2026 09:28:41 +0200	[thread overview]
Message-ID: <20260701-rigorous-analytic-mackerel-449703@quoll> (raw)
In-Reply-To: <20260630071022.3256-2-yuanjie.yang@oss.qualcomm.com>

On Tue, Jun 30, 2026 at 03:10:11PM +0800, Yuanjie Yang wrote:
> Document the device tree binding for the HAMOA-IOT-COME board, which uses
> the Qualcomm X1E80100 SoC.
> 
> The system consists of a SoM mounted on a carrier board. The HAMOA-IOT-COME
> SoM integrates the core system, including a SiP that contains the SoC and

This is contradictory to the code. Your binding said you are using IOT
SoM, not IoT COME SoM.

> related components.
> 
> Hierarchy:
> 
>     Carrier Board
>         -> SoM
>             -> SiP
>                 -> SoC

Drop. Compatibles define that.

> 
> The SiP on the HAMOA-IOT-COME SoM is equivalent to the HAMOA-IOT-EVK SoM.

I don't even know what does it mean. How two different hardware can be
equivalent? Are they the same? Are you creating duplicated compatibles
for same hardware?

Best regards,
Krzysztof


  reply	other threads:[~2026-07-01  7:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30  7:10 [PATCH 0/2] Initial support for Qualcomm Hamoa IOT COME board Yuanjie Yang
2026-06-30  7:10 ` [PATCH 1/2] dt-bindings: arm: qcom: Document HAMOA-IOT-COME board Yuanjie Yang
2026-07-01  7:28   ` Krzysztof Kozlowski [this message]
2026-07-01  8:47     ` yuanjiey
2026-06-30  7:10 ` [PATCH 2/2] arm64: dts: qcom: Add base " Yuanjie Yang
2026-06-30  7:26   ` sashiko-bot
2026-06-30  9:37     ` yuanjiey
2026-07-01  7:29   ` Krzysztof Kozlowski
2026-07-01  8:51     ` yuanjiey
2026-07-01 10:19       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701-rigorous-analytic-mackerel-449703@quoll \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=yuanjie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox