From: sashiko-bot@kernel.org
To: "Adrian Ng Ho Yin" <adrian.ho.yin.ng@altera.com>
Cc: Frank.Li@kernel.org, conor+dt@kernel.org, robh@kernel.org,
dmaengine@vger.kernel.org, vkoul@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: altr,msgdma: update maintainer
Date: Wed, 01 Jul 2026 02:44:58 +0000 [thread overview]
Message-ID: <20260701024459.AEB321F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260701023455.36330-1-adrian.ho.yin.ng@altera.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit updates the maintainer in the DT binding YAML file but fails to update the corresponding entry in the global MAINTAINERS file.
--
commit db17ec175a921c83db0dc0de95284d7a5faee871
Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
dt-bindings: altr,msgdma: update maintainer
This commit updates the maintainer for the Altera mSGDMA IP core from
Olivier Dautricourt to Adrian Ng Ho Yin in the device tree binding file.
> diff --git a/Documentation/devicetree/bindings/dma/altr,msgdma.yaml b/Documentation/devicetree/bindings/dma/altr,msgdma.yaml
> index 391bf58386025..bea302b894534 100644
> --- a/Documentation/devicetree/bindings/dma/altr,msgdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/altr,msgdma.yaml
> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Altera mSGDMA IP core
>
> maintainers:
> - - Olivier Dautricourt <olivierdautricourt@gmail.com>
> + - Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
[Severity: Medium]
Does the global MAINTAINERS file also need to be updated to reflect this
change?
Currently, the MAINTAINERS file still points to the previous maintainer:
MAINTAINERS:
ALTERA MSGDMA IP CORE DRIVER
M: Olivier Dautricourt <olivierdautricourt@gmail.com>
R: Stefan Roese <sr@denx.de>
Without updating this global file, get_maintainer.pl will still return the
previous maintainer for patches touching the driver code.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260701023455.36330-1-adrian.ho.yin.ng@altera.com?part=1
next prev parent reply other threads:[~2026-07-01 2:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 2:34 [PATCH] dt-bindings: altr,msgdma: update maintainer Adrian Ng Ho Yin
2026-07-01 2:44 ` sashiko-bot [this message]
2026-07-01 7:36 ` Krzysztof Kozlowski
2026-07-01 8:21 ` Vinod Koul
2026-07-01 13:02 ` Ng, Adrian Ho Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701024459.AEB321F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox