Re: [PATCH v3 1/2] dt-bindings: memory-controllers: mtk-smi: Add support for mt8189

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added compatible string `mediatek,mt8189-smi-common` is omitted from the `if-then` generational conditional blocks that define strict clock constraints.
- [Low] The SoC generation list in the binding description was not updated to include mt8189.
--

commit 6c2bad5d055d1f72dd33d20414abab2cdf2654cb
Author: Zhengnan Chen <zhengnan.chen@mediatek.com>

dt-bindings: memory-controllers: mtk-smi: Add support for mt8189
    
Add smi larb, common and sub-commom binding description for mt8189.

> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> index 0762e0ff66ef0..4e1deeff92b14 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> @@ -25,6 +25,21 @@ description: |
>    SMI generation 1 to transform the smi clock into emi clock domain, but that is
>    not needed for SMI generation 2.

[Severity: Low]
This isn't a bug, but the generation 2 SoC list earlier in this description
block reads: "generation 2: mt2712, mt6779, mt8167, mt8173, mt8183, mt8186,
mt8188, mt8192 and mt8195." Should mt8189 be added to this list as well?

> +  The smi-common connects with smi-larb and IOMMU. The maximum inputs number of
> +  a smi-common is 8. In SMI generation 2, the engines number may be over 8.

[ ... ]

> @@ -40,6 +55,8 @@ properties:
>            - mediatek,mt8186-smi-common
>            - mediatek,mt8188-smi-common-vdo
>            - mediatek,mt8188-smi-common-vpp
> +          - mediatek,mt8189-smi-common
> +          - mediatek,mt8189-smi-sub-common

[Severity: Medium]
Is mediatek,mt8189-smi-common missing from the generational conditional blocks
that enforce strict clock constraints?

Looking further down in mediatek,smi-common.yaml at the allOf block:

  - if:  # for gen2 HW that have gals
      properties:
        compatible:
          enum:
            - mediatek,mt6779-smi-common
            - mediatek,mt8183-smi-common
            ...

If mt8189-smi-common shares the same clock constraints as these Gen 2 devices,
omitting it from this conditional block will cause device trees with invalid
clock configurations to silently pass validation. Should it be added to the
enum list here (or the corresponding Gen2 block without gals)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701074533.175803-1-Congcong.Yao@mediatek.com?part=1