Re: [PATCH V3 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `supports-cqe` property for eMMC in `monaco-evk.dts`.
--

commit 5c91ec5c205c89bd965c17fc6805d964575e0468
Author: Monish Chunara <monish.chunara@oss.qualcomm.com>

arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT

This commit removes the 'supports-cqe' property from the Monaco SoC device
tree to allow SD card compatibility, and moves it into the board-specific
device trees that use eMMC.

> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> index 7b1d57460f1e6..e5f316897706b 100644
> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi
> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
> @@ -4828,7 +4828,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>  			qcom,dll-config = <0x000f64ee>;
>  			qcom,ddr-config = <0x80040868>;
>  			bus-width = <8>;
> -			supports-cqe;
>  			dma-coherent;
>  
>  			mmc-ddr-1_8v;

[Severity: High]
Does this unintentionally drop CQE support for the monaco-evk board?

The &sdhc_1 node in arch/arm64/boot/dts/qcom/monaco-evk.dts configures the
controller for eMMC:

&sdhc_1 {
	vmmc-supply = <&vreg_l8a>;
	vqmmc-supply = <&vreg_s2s>;

	no-sd;
	no-sdio;
	non-removable;

	status = "okay";
};

Since supports-cqe is removed from the base monaco.dtsi here, but is not
explicitly added to monaco-evk.dts in this patch, booting the standalone
monaco-evk.dtb will now bring up eMMC without Command Queue Engine support.

Should monaco-evk.dts be updated alongside the other boards in this patch
to prevent a performance regression?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701081715.2580329-1-monish.chunara@oss.qualcomm.com?part=1