Re: [PATCH v3 2/2] arm64: dts: imx8mp-skov: support new 7inch panel board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] DT Schema Validation Failure: missing fallback compatible string for touchscreen.
- [Low] Documentation error in LVDS clock calculation comment.
- [Low] Makefile Ordering Violation.
--

commit 3b909b83ea0bf98186df799556b414671ad39311
Author: Steffen Trumtrar <s.trumtrar@pengutronix.de>

arm64: dts: imx8mp-skov: support new 7inch panel board
    
This board is similar to the already upstream
imx8mp-skov-revc-tian-g07017.dts but uses a different 7" panel with a
different touch controller.

> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 8ddaab127ab9c..efca29735b2cb 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile

[ ... ]

> @@ -435,6 +435,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-mi1010ait-1cp1.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-bd500.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-hdmi.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-tian-g07017.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt070tm041.dtb

[Severity: Low]
This isn't a bug, but should this new entry be sorted alphabetically?
Placing jutouch after tian breaks the expected ordering in the Makefile.

>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revc-jutouch-jt101tm023.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-toradex-smarc-dev.dtb

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts
> new file mode 100644
> index 0000000000000..56374f1e67663
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dts

[ ... ]

> +&i2c2 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	touchscreen@2a {
> +		compatible = "eeti,exc81w32";

[Severity: Low]
Does this compatible string also require the fallback string eeti,exc80h84
to pass dtbs_check validation? The schema for the eeti,exc3000 touchscreen
typically expects both strings to be present.

> +		reg = <0x2a>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touchscreen>;

[ ... ]

> +&lvds_bridge {
> +	assigned-clocks = <&clk IMX8MP_CLK_MEDIA_LDB>,
> +				 <&clk IMX8MP_VIDEO_PLL1>;
> +	assigned-clock-parents = <&clk IMX8MP_VIDEO_PLL1_OUT>;
> +	/* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 2 * 7 */

[Severity: Low]
This isn't a bug, but is the * 2 multiplier in this comment correct?

With the single-link pixel clock of 51.2 MHz for this panel and the assigned
rate of 358400000 Hz, the calculation appears to be exactly 51.2 MHz * 7.
Including the * 2 multiplier would result in 716.8 MHz instead.

> +	assigned-clock-rates = <0>, <358400000>;
> +	status = "okay";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v3-0-d74f7e3f8293@pengutronix.de?part=2