Re: [PATCH 2/2] cpufreq: qcom-nvmem: Add IPQ5210 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the function `qcom_cpufreq_kryo_name_version()` triggers a kernel `BUG()` panic when the SMEM SoC ID is not recognized, rather than gracefully failing.
--

commit efa443e3ef471a943647c359a1a0b9da9950bda0
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

cpufreq: qcom-nvmem: Add IPQ5210 support

IPQ5210 SoCs expose CPU frequency limits through an eFuse speed bin, and
the valid CPU OPPs depend on the SoC variant. This patch adds IPQ5210
support to the Qualcomm NVMEM cpufreq driver and blocks the generic
cpufreq-dt platform device.

[ ... ]

> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index e6d28d162442a..b2aeda7c564a9 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -200,6 +200,13 @@ static int qcom_cpufreq_kryo_name_version(struct device *cpu_dev,
>  	case QCOM_ID_IPQ9574:
>  		drv->versions = 1 << (unsigned int)(*speedbin);
>  		break;
> +	case QCOM_ID_IPQ5200:
> +	case QCOM_ID_IPQ5210:
> +	case QCOM_ID_QCF2200:
> +	case QCOM_ID_QCF3200:
> +	case QCOM_ID_QCF3210:
> +		drv->versions = (*speedbin != 0xcd) ? BIT(0) : BIT(1);
> +		break;

[Severity: High]
This is a pre-existing issue, but should the default case for this switch
statement continue to use BUG() when an unhandled msm_id is encountered?

If a device tree successfully matches the driver, but the SMEM SoC ID
returned by qcom_smem_get_soc_id() is unexpected (such as from a mismatched
device tree, firmware issue, or prototype hardware),
qcom_cpufreq_kryo_name_version() will hit the default case:

        default:
                BUG();
                break;

Would it be safer to return an error code like -ENODEV here instead of
triggering an immediate kernel panic during device probe?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-cpufreq-v1-0-98656ad20ff3@oss.qualcomm.com?part=2