Re: [PATCH V5 7/7] arm64: dts: imx95: Move power supply properties to Root Port node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The transition to the new PCI pwrctrl framework is incomplete across the i.MX95 platform. Several other i.MX95 board definitions were omitted from this migration and still retain the legacy `vpcie-supply` property in the host controller node instead of moving them to the Root Port child nodes.
--

commit b94f7498d750422b57ec34a9401c66058aec3470
Author: Sherry Sun <sherry.sun@nxp.com>

arm64: dts: imx95: Move power supply properties to Root Port node

Move the power supply properties from the PCIe controller nodes to the
Root Port child nodes to support the new PCI pwrctrl framework.

> Move the power supply properties from the PCIe controller nodes to the
> Root Port child nodes to support the new PCI pwrctrl framework.
> 
> Since i.MX95 is the new platform that under development phase, it should
> be fine to simply move the power supply properties.

[Severity: Low]
Are there other i.MX95 boards that should be included in this migration?

The transition to the new PCI pwrctrl framework appears incomplete across the
i.MX95 platform. Several other i.MX95 board definitions were omitted from this
migration and still retain the legacy vpcie-supply property in the host
controller node instead of moving them to the Root Port child nodes.

For example, arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts retains the
legacy power supply property in the host controller node:

&pcie0 {
    ...
    vpcie-supply = <&reg_m2_mkey_pwr>;
    ...
};

Similar omissions appear in arch/arm64/boot/dts/freescale/imx95-19x19-frdm-pro.dts:

&pcie0 {
    ...
    vpcie-supply = <&reg_m2_mkey_1_pwr>;
    ...
};

And in arch/arm64/boot/dts/freescale/imx95-19x19-verdin-evk.dts:

&pcie0 {
    ...
    vpcie-supply = <&reg_pcie0>;
    ...
};

Should these boards also be updated to ensure consistent power management
behavior across the i.MX95 platform and allow future cleanup of the legacy
code?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701105234.198987-1-sherry.sun@oss.nxp.com?part=7