From: sashiko-bot@kernel.org
To: "Pavel Löbl" <pavel@loebl.cz>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: clock: si544: add si549 compatible
Date: Wed, 01 Jul 2026 13:25:28 +0000 [thread overview]
Message-ID: <20260701132529.9C69B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260701130927.3858536-2-pavel@loebl.cz>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The updated datasheet URL for Si544 uses 'SkyWorks' with a capital 'W', which is inconsistent with the other URLs and may result in a broken link.
- [Low] The dt-binding title and description were not updated to include the newly added Si549 variants.
--
commit 4f4bdd2bd1e69ffb4c086f281e4a07d3aa408d53
Author: Pavel Löbl <pavel@loebl.cz>
Subject: dt-bindings: clock: si544: add si549 compatible
This commit adds the Si549 compatible strings to the silabs,si544 clock
binding. It also updates the datasheet URLs to point to Skyworks Solutions
following their acquisition of Silicon Labs.
> diff --git a/Documentation/devicetree/bindings/clock/silabs,si544.yaml b/Documentation/devicetree/bindings/clock/silabs,si544.yaml
> index f87e718671080..680bc71afd1e2 100644
> --- a/Documentation/devicetree/bindings/clock/silabs,si544.yaml
> +++ b/Documentation/devicetree/bindings/clock/silabs,si544.yaml
> @@ -13,8 +13,9 @@ description: >
> Silicon Labs 514/544 programmable I2C clock generator. Details about the device
[Severity: Low]
Do the title and description in this document need to be updated to
include the newly added Si549 variants?
> can be found in the datasheet:
>
> - https://www.silabs.com/Support%20Documents/TechnicalDocs/si514.pdf
> - https://www.silabs.com/documents/public/data-sheets/si544-datasheet.pdf
> + https://www.skyworksinc.com/-/media/Skyworks/SL/documents/public/data-sheets/Si514.pdf
> + https://www.skyworksinc.com/-/media/SkyWorks/SL/documents/public/data-sheets/si544-datasheet.pdf
[Severity: Low]
Is the capitalized SkyWorks intentional in this URL?
It is inconsistent with the lowercase Skyworks usage in the other URLs on
adjacent lines. This might lead to a broken link if the web server is
case-sensitive.
> + https://www.skyworksinc.com/-/media/Skyworks/SL/documents/public/data-sheets/si549-datasheet.pdf
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260701130927.3858536-1-pavel@loebl.cz?part=1
next prev parent reply other threads:[~2026-07-01 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:09 [PATCH 0/2] Add support for Si549 programmable clock Pavel Löbl
2026-07-01 13:09 ` [PATCH 1/2] dt-bindings: clock: si544: add si549 compatible Pavel Löbl
2026-07-01 13:25 ` sashiko-bot [this message]
2026-07-01 13:09 ` [PATCH 2/2] clk: si544: add support for si549 Pavel Löbl
2026-07-01 13:33 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260701132529.9C69B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pavel@loebl.cz \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox