From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC3D401492; Wed, 1 Jul 2026 15:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782918374; cv=none; b=VgMVPRR3Ts4QTUTATvH07idaTcGGq6MJz5w7mq/zySGqGx0CeUnQYdzsu5pvJOllM45yNHwH6ai0MCH0FLy36w99YHYQX8rQMZIIxB82K8Rs6VoXzxD+31xtOr5tce5i5IeZPqNHz2ZboJL0nWnW+fEk5eFkFhXryXN55PEtyhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782918374; c=relaxed/simple; bh=40DAFIKcf6IQceQcuuDpe4FoxoaNob9uttMJyD75Zbo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L+/LD/E1FgqqvxHDgrhO1almo1eXzCRBbLBMD4OL6CPgYwOt8Oah4RHwNLAEzNyxoS2jLuOoEUF32IsIdQGMPHvLrjKXZBSitLr1RcXP2Zqkzu0mxnPNSp74dmJwL5Pu6roSSpGc5ShpLGYfkFMmCBA/DMhjGEPTgtI03LhuPg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JLv7Ai2y; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JLv7Ai2y" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 15531C504E2; Wed, 1 Jul 2026 15:06:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0A64460288; Wed, 1 Jul 2026 15:06:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 89E6C104C9645; Wed, 1 Jul 2026 17:06:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782918368; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=BjhULqYYe7aqWqvOdN5jU6JmlKc3RFwCqnUuIsbeyD4=; b=JLv7Ai2yY6blvstUvW3ztpWuaqzlMgb1OZsGbyufFN0tuKY8MF14/EhvfK0iqJTIXYxXlC iMcc82BsKs1eFYCi64PUIyx/sgXkAePL9LOu99ZRKfga6KlmHwH2aAnm3C7Et2GJATOKU8 baSQvvz2LReir8Hs+pjfJ0l7W2Vnv3cZT6azWlATwKH0gIsABHhGjZBjPL2qexVbZoTjUg ooOYoyhyobJJHbxIKLSPAKArlZlbBwMgNk6k0osnpkyLmMpRPGM8NDM9FIHsvs6Pk9ZJQA K/ChPLWTCUx4tc+MLKzOS+tVJE0cgRDIxwgB8LulUCm3txoxgRX73ne7mtMbgA== Date: Wed, 1 Jul 2026 17:06:04 +0200 From: Alexandre Belloni To: Markus Probst Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add sii,wakealarm-output-pin property for S35390A Message-ID: <202607011506045358209c@mail.local> References: <20260630-rtc_s35390a_int1-v1-0-1b2239e16be2@posteo.de> <20260630-rtc_s35390a_int1-v1-1-1b2239e16be2@posteo.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630-rtc_s35390a_int1-v1-1-1b2239e16be2@posteo.de> X-Last-TLS-Session-Version: TLSv1.3 On 30/06/2026 19:22:21+0000, Markus Probst wrote: > Synology NAS devices use the output pin for interrupt signal 1 to wake up > the system. > > Move devicetree bindings for sii,s35390a into its own file. > Add sii,wakealarm-output-pin property to enable the use of the output > pin for interrupt signal 1 for the wake alarm, which makes it possible to > set an wake alarm on Synology NAS devices. > > Signed-off-by: Markus Probst > --- > .../devicetree/bindings/rtc/sii,s35390a.yaml | 54 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/trivial-rtc.yaml | 3 -- > MAINTAINERS | 1 + > include/dt-bindings/rtc/s35390a.h | 9 ++++ > 4 files changed, 64 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml > new file mode 100644 > index 000000000000..31a578673870 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/sii,s35390a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: S-35390A 2-WIRE REAL-TIME CLOCK > + > +maintainers: > + - Alexandre Belloni > + > +description: > + The S-35390A is a CMOS 2-wire real-time clock IC which operates with the > + very low current consumption in the wide range of operation voltage. > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + const: sii,s35390a > + > + reg: > + maxItems: 1 > + > + sii,wakealarm-output-pin: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2] > + description: | > + The output pin to wake up the system. > + Default will use the output pin for interrupt signal 2. > + : Output pin for interrupt signal 1 > + : Output pin for interrupt signal 2 > + Ideally, we'd get a proper pinctrl driver part for this because what happens if you want interrupts on both pin or clock output on both pins or any combination of interrupts and clocks? -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com