Re: [PATCH v2 4/4] arm64: dts: mediatek: add Genio 520-EVK board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree fails to compile due to missing header/dtsi includes and undefined MT6359 PMIC node references.
--

commit 4a56bfd2875ac1171a204b6c914828f4d8d05173
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

arm64: dts: mediatek: add Genio 520-EVK board

Add devicetree for the basic hardware enablement of the Genio 520-EVK
board, based on MT8371 SoC.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8371-genio-520-evk.dts b/arch/arm64/boot/dts/mediatek/mt8371-genio-520-evk.dts
> new file mode 100644
> index 0000000000000..b4fd343bc08a6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8371-genio-520-evk.dts
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2025 Collabora Ltd.
> + * Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
> + */
> +/dts-v1/;
> +
> +#include "mt8189.dtsi"
> +#include "mt8391-genio-common.dtsi"

[Severity: Low]
Will this devicetree compile cleanly? It appears that the included files
(mt8189.dtsi and mt8391-genio-common.dtsi) rely on headers and dtsi files
that are missing from the tree (such as <dt-bindings/clock/mediatek,mt8189-clk.h>,
mt6365.dtsi, and mt8189-pinfunc.h).

Additionally, mt8391-genio-common.dtsi overrides MT6359 PMIC nodes
(e.g., &mt6359_va09_ldo_reg), which seem undefined since the board uses
an MT6365 PMIC.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-add-mediatek-genio-520-720-evk-v2-0-19d5da4ef984@collabora.com?part=4