From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D4E4C77C5 for ; Wed, 1 Jul 2026 18:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782930114; cv=none; b=SbZGjN2HbypmOG2yP1JzVefAvY/TT4DB3VdxTng0ti6mbWiU/GVyznOVCrRjPg+yOb5+cmRhc4xuSfVEddGJT6YOFTYEPWaKwT9Kqn/dDhwnUXdSG5hZ+1xJcRa1vbNQyByz4Pg6+DoarGvhqH3VU+C+nKUhMiTRWglRw4gmzMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782930114; c=relaxed/simple; bh=PLDgEc0Do2H22VGlCYrVwfUGPhkJd01zB9Iyt0tGQss=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=MafV89B5+aG8Q8KTz43sCsvxamLMu6w0R9603j9oTWuIQ7DoMM+dh78Wus6Ed+wVW0FpAhAL6dOkaaoqHpfdMObO4nr70yXqnkHwO0lP+uzwh7fTN2MdcbcpKE8xmNeetXGi1wFI0Aozo4ej6j60zdQvyoknfn728WbRzv195yo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fiGhmemA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fiGhmemA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5B61F000E9; Wed, 1 Jul 2026 18:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782930113; bh=lwAYNdGRQJvdl/y+QcVpExOkwxdxmvigdC1NE6Ejr6k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fiGhmemA7WK7yzzjmiBtoIQkAXnMLHqSvb/JU+6uvFvf9KRyoAhjCn4JT/Yt8UVW3 deIWO87+5YwD/i3U57sB4BtEBadSdS6N8sCtT1oBlfHa4eYNOuGAPEFShBjASzkzjd 2mOeidO/mVmkzyKvmjChpxZrQu6AElEAZPJoGAMC2s9f6OrKuHRdqiWxtXZKyqf/Ot eiE5rH9ZBKTtjcgTjidKj0S6QIigunOOlz3z5M7uGm2N7jrlQomPgpcGAwPivPotj2 PEGfWvhDWUF2I8Umy2U7UjhDi8CfVb23CR5tLSjti9CeCpTa5wsY9FyTta/qZwPP4d FQNDfBgoDm+9w== From: sashiko-bot@kernel.org Subject: Re: [PATCH] ARM: dts: am33xx: avoid invalid OCP device-link for timer1 and timer2 Reply-To: sashiko-reviews@lists.linux.dev To: "Wagner Popov dos Santos" Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20260701175647.8694-1-wpopov@gmail.com> References: <20260701175647.8694-1-wpopov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 01 Jul 2026 18:21:52 +0000 Message-Id: <20260701182153.0F5B61F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Using the undocumented, Linux-internal `post-init-providers` pro= perty to silence an OS warning. -- commit be227235cebc7285a11a56bcbf6975ef2b78f927 Author: Wagner Popov dos Santos ARM: dts: am33xx: avoid invalid OCP device-link for timer1 and timer2 This patch updates dependency handling for timer1 and timer2 on AM335x/UCC3. It adds post-init-providers to the device nodes to avoid boot-time fw_devlink errors caused by invalid link-creation attempts. > diff --git a/arch/arm/boot/dts/ti/omap/am33xx.dtsi b/arch/arm/boot/dts/ti= /omap/am33xx.dtsi > index ca3e7f5d7d0dc..760598d5ae1c9 100644 > --- a/arch/arm/boot/dts/ti/omap/am33xx.dtsi > +++ b/arch/arm/boot/dts/ti/omap/am33xx.dtsi > @@ -708,6 +708,7 @@ &timer1_target { > timer@0 { > assigned-clocks =3D <&timer1_fck>; > assigned-clock-parents =3D <&sys_clkin_ck>; > + post-init-providers =3D <&ocp>; [Severity: Medium] Does this introduce a regression by using an undocumented Linux-specific property in the Device Tree to silence an OS warning here in timer1_target? Since Device Tree is intended to be an OS-agnostic hardware description, adding this internal Linux fw_devlink mechanism pollutes the DT with an OS-specific probing workaround. Would it be better to fix this regression in the driver core instead? Perhaps patching fw_devlink_create_devlink() to gracefully skip link creati= on when the resolved supplier is an ancestor of the consumer would address the root cause without adding OS-specific properties to the DT. > }; > }; > =20 > @@ -721,5 +722,6 @@ &timer2_target { > timer@0 { > assigned-clocks =3D <&timer2_fck>; > assigned-clock-parents =3D <&sys_clkin_ck>; > + post-init-providers =3D <&ocp>; [Severity: Medium] Does this node for timer2_target introduce the same regression mentioned above? > }; > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260701175647.8694= -1-wpopov@gmail.com?part=3D1