From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36F42382398; Wed, 1 Jul 2026 19:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782935981; cv=none; b=gI44FIh0AQ4yY/CbK9n7L9ovjgofkn+cTBNWQHzp3707tTwUSyuzHUkWEkWe+HqHLPcrIoQJwwfP0pdcxADBVf0nGsBRu0QG/o3uClrFayacpe5AY1LhB+CBQ1amQ7iq3oWSZC23kIUg8vKmoorMCgNkG9MBL9OTahd5Ai0RhiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782935981; c=relaxed/simple; bh=/tBUKj0iY/StXCr0MKuI7jY9NHQeAKTir4Bj7Y5/fXU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kjMtc++TSqsgvo/q1GcTnOjG1fT0AYzrB+LMRjao77em37uJFx83jW3xUN32ZzqLT+7cBIt6PqAgU4Vbz+aqERc9MdwRwRoJPNHj+XTdN6aTgFvNk53GFpmPnLklYKyrZh5gzMUf3QtZnf5TYOXJpNFrCWR2KGdHpVFuZwnd4ts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KYJIfpFW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KYJIfpFW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22C3C1F000E9; Wed, 1 Jul 2026 19:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782935979; bh=GB7+AJUFtH9rafXyLhJpbth0HCa2w5+qr4sa9ZK2T90=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=KYJIfpFWJrroGCOuC0DlQlZ5S2W0wpePeAuIQgTbUcJDEUhUi5DLHSIr2RXhGLdYh aU8VWWBSA/J7gp4jH+QfN7IuJfpCHYy4IUbjlznolNmBpvXqXYpTgdgD1Ht89J7+PT ay7muYbvSp1UVeHFL3aJol263Z9Oo6tqepGILjkVaTu7SLuB1GNvuX+IxueJRXm/Xb jgiLUfNCCOdbKslHpPEVwVZjyi4d1Dgkvi8gP3JvyrEIfL40HAICRUDsBE8fYe1KZN Lql+PiT0U9eTqKiTrYngh/JYBr7xGpvA/dzEnDhaYpn8mzoDDaqxWV3Cfn9G6vf1vG XlD1Kxa125voA== Date: Wed, 1 Jul 2026 20:59:35 +0100 From: Jonathan Cameron To: "David Lechner (TI)" Cc: Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Hall , Patrick Edwards , Kurt Borja , Nguyen Minh Tien , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/8] iio: adc: add ti-ads112c14 driver Message-ID: <20260701205935.0765c2ba@jic23-huawei> In-Reply-To: <20260625-iio-adc-ti-ads122c14-v2-6-ceb9b0b561cb@baylibre.com> References: <20260625-iio-adc-ti-ads122c14-v2-0-ceb9b0b561cb@baylibre.com> <20260625-iio-adc-ti-ads122c14-v2-6-ceb9b0b561cb@baylibre.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 25 Jun 2026 16:55:08 -0500 "David Lechner (TI)" wrote: > Add a new driver for the TI ADS112C14/ADS122C14 ADC chips. > > This first step is adding a very basic driver that only supports power > on/reset and reading the system monitor channels. > > ADS112C14_SYS_MON_CHANNEL_SHORT is the last channel rather than being in > logical order by address to keep the voltage channels together and in > case we find we need to add variants of this channel with different > voltage reference later. > > Signed-off-by: David Lechner (TI) Really trivial comments below. > diff --git a/drivers/iio/adc/ti-ads112c14.c b/drivers/iio/adc/ti-ads112c14.c > new file mode 100644 > index 000000000000..c61d47244732 > --- /dev/null > +++ b/drivers/iio/adc/ti-ads112c14.c ... > + > + /* Write magic reset value (0x16) to ensure known state.*/ Space before */ > + ret = regmap_write(data->regmap, ADS112C14_REG_CONVERSION_CTRL, > + FIELD_PREP(ADS112C14_CONVERSION_CTRL_RESET, 0x16)); ... > +static const struct ads112c14_chip_info ads122c14_chip_info = { > + .name = "ads122c14", > + .resolution_bits = 24, Might be a good idea to have expected stuff for DEVICE_ID in here as well. Whilst we don't want to reject a missmatch (for dt fallback) reasons, it is nice to print if we see one as a hint something that might be unexpected is going on. > +};