Re: [PATCH 1/3] dt-bindings: soc: apple: Add bindings for apple PMGR misc controls

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3293 bytes --]

On Thu, Jul 02, 2026 at 02:06:26PM +0200, Sasha Finkelstein wrote:
> Certain Apple SoCs include additional PMGR power states that are
> controlled via a different "misc" control block. On existing SoCs, this
> includes the fabric and memory controller state.
> 
> Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
> ---
>  Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  MAINTAINERS                                                            |  1 +
>  2 files changed, 46 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml b/Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml
> new file mode 100644
> index 000000000000..30abedc67fa4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/apple/apple,t6000-pmgr-misc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple SoC PMGR Misc Power States
> +
> +maintainers:
> +  - Sasha Finkelstein <k@chaosmail.tech>
> +
> +description: |
> +  Certain Apple SoCs include additional PMGR power states that are controlled
> +  via a different "misc" control block. On existing SoCs, this includes the
> +  fabric and memory controller state.

Are t6000 and t6020 the "certain Apple SoCs"? I assume so. The bit about
"existing SoCs" is confusing in a binding (although it would be ok in the
commit message), because you run into language semantics that imply that
this sentence is about devices to the ones you're addressing here. I
think you can just do s/. On existing SoCs//. And add an s to the final
"state" to make it "states".

> +
> +properties:
> +  compatible:
> +    enum:
> +      - apple,t6000-pmgr-misc
> +      - apple,t6020-pmgr-misc
> +
> +  reg:
> +    maxItems: 2
> +
> +  reg-names:
> +    items:
> +      - const: fabric-ps
> +      - const: dcs-ps

"dcs" means memory controller then?

> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    pmgr_misc: power-management@8e20c000 {

If there's a new version, drop the unused label here please.

> +        compatible = "apple,t6000-pmgr-misc";
> +        reg = <0x8e20c000 0x400>,
> +              <0x8e20c800 0x400>;
> +        reg-names = "fabric-ps", "dcs-ps";
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 15011f5752a9..5a29bb86499f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2607,6 +2607,7 @@ F:	Documentation/devicetree/bindings/power/apple*
>  F:	Documentation/devicetree/bindings/power/reset/apple,smc-reboot.yaml
>  F:	Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml
>  F:	Documentation/devicetree/bindings/rtc/apple,smc-rtc.yaml
> +F:	Documentation/devicetree/bindings/soc/apple/apple,t6000-pmgr-misc.yaml
>  F:	Documentation/devicetree/bindings/spi/apple,spi.yaml
>  F:	Documentation/devicetree/bindings/spmi/apple,spmi.yaml
>  F:	Documentation/devicetree/bindings/usb/apple,dwc3.yaml
> 
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]