From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F0FD320A37; Thu, 2 Jul 2026 18:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783018530; cv=none; b=opdB3kLDFJ4P0PS8e81GzOYKPmKvC4qhxCyJTtm/GoajUGDrNqqBcJVMgC9wz6ektqQTxpdDI71DIWBBdIf1EKc3RWG9nh7D68ziFj/aeJcm5Ozvng4eHbdCalYUpNlFiwcOfrjcd2mMnQLtUR9qOUHRFUwZYGGOo6Daup8Dk7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783018530; c=relaxed/simple; bh=fZoXJ0otB5ZNc3pKIpIeJIi0McT27o2uRePOmhSRLr4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fxUfKUJTfYo9wh1e1mzLzf707cEG3rLVCDH1OnenmwLlsCiIhzfQbpMCSfNVOVuTCOSpuRC3zNrKTL08dHc8dsvkT4MW7bq910i8L7Pfm5deYrjkul4JynhQ8UlMKHiGQWcLTSh40qyBtihuA1KriADGH7XeHdvtweYwxPLFtT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NacNS6bg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NacNS6bg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FB9B1F000E9; Thu, 2 Jul 2026 18:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783018529; bh=fNS4tqccb04+QtS0h43Z588lZs7oUTCl9VD/wpTFlbQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NacNS6bg/nGPS5YUVw5jH76wz5YShTWSyyE8s+P9wfrl2yzgf4tTqcvZHd84S/7Dg DDaRntRlSXAQmnWC9ElrOfi+TuWSbnb7FQi3I4Te4lO1VsC4K6hrneeJsRSTr2B5hG v60VUaXomKc6i8I8XKVWIzjnJsOPFhn0XrSMskbWikxlCGMT2LKUKUChoG6CXUGT5h koccK0yAKwj+292C599zTt87zjQ+SsCFkTAFkjKlxCEFClwz47A+xtLqXaKv6pEn3h 51yzH/sYvncroPFkvHbxw8GTs8sxwIWGve6jNtawVKeMepHRu8pziEf52iuZ80c7LE 4SHH3bL6VawbA== Date: Thu, 2 Jul 2026 19:55:21 +0100 From: Conor Dooley To: Kyrie Wu =?utf-8?B?KOWQtOaZlyk=?= Cc: AngeloGioacchino Del Regno , "laurent.pinchart+renesas@ideasonboard.com" , "nicolas.dufresne@collabora.com" , "jacopo.mondi@ideasonboard.com" , Yunfei Dong =?utf-8?B?KOiRo+S6kemjnik=?= , "conor+dt@kernel.org" , Irui Wang =?utf-8?B?KOeOi+eRnik=?= , "rongqianfeng@vivo.com" , "tzungbi@kernel.org" , "tfiga@chromium.org" , "robh@kernel.org" , "wenst@chromium.org" , "benjamin.gaignard@collabora.com" , "matthias.bgg@gmail.com" , "haoxiang_li2024@163.com" , "ribalda@chromium.org" , Tiffany Lin =?utf-8?B?KOael+aFp+ePiik=?= , "linux-mediatek@lists.infradead.org" , "p.zabel@pengutronix.de" , "sebastian.fricke@collabora.com" , "fshao@chromium.org" , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "mchehab@kernel.org" , "fanwu01@zju.edu.cn" , "linux-arm-kernel@lists.infradead.org" , Andrew-CT Chen =?utf-8?B?KOmZs+aZuui/qik=?= , "krzk+dt@kernel.org" , "hverkuil+cisco@kernel.org" , "linux-kernel@vger.kernel.org" , "kees@kernel.org" , "sakari.ailus@linux.intel.com" Subject: Re: [PATCH v5 11/14] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8196 Message-ID: <20260702-parlor-disband-fdc2f049336c@spud> References: <20260603084045.17488-1-kyrie.wu@mediatek.com> <20260603084045.17488-12-kyrie.wu@mediatek.com> <20260603-pentagram-unleveled-8729d0003aa7@spud> <6cb7ae4a09d476a04ceefca50564646712ad391b.camel@mediatek.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JdEKl3bSogEo/Lcd" Content-Disposition: inline In-Reply-To: <6cb7ae4a09d476a04ceefca50564646712ad391b.camel@mediatek.com> --JdEKl3bSogEo/Lcd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2026 at 05:39:24AM +0000, Kyrie Wu (=E5=90=B4=E6=99=97) wro= te: > On Wed, 2026-06-03 at 17:14 +0100, Conor Dooley wrote: > > On Wed, Jun 03, 2026 at 04:40:41PM +0800, Kyrie Wu wrote: > > > From: Yunfei Dong > > >=20 > > > The MT8196 decoder differs from previous generations in several > > > key aspects, most notably in its use of VCP instead of SCP. > > > Additionally, the MT8196 enhances codec capabilities by supporting > > > HEVC Main10 profile decoding. To accommodate these hardware > > > changes, > > > the binding constraints specify a total of 12 clock inputs, > > > consisting of 9 decoder clocks and 3 VCP interface clocks, > > > along with 2 power domains covering both the decoder and VCP > > > subsystems. > >=20 > > I'm pretty pretty confused by this statement about constraints, since > > there's none added? > > The vcodec-dec node doesn't even seem to permit clocks at all? > >=20 > Dear Conor, >=20 > I apologize for any confusion my commit message caused. What I wanted > to convey was the hardware differences between the MT8196 and previous > ICs. If you feel that the VCP and clock information are not suitable > for this location, I would like to rewrite the commit message as > follows: > Compared to previous ICs, the MT8196 supports a 10-bit decoder and has > a decoding capability of 4K@120fps, using a dual hardware decoding > architecture of LAT+CORE. Sure? But your comments about the constraints are odd and I do not know if that means you omitted changing constraints when you should have? For example, using lat+core only permits you 10 input clocks but your commit message talks about 12. >=20 > Thanks. >=20 > Regards, > Kyrie. > > >=20 > > > Signed-off-by: Yunfei Dong > > > Acked-by: Nicolas Dufresne > > > --- > > > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml |= =20 > > > 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git > > > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev- > > > decoder.yaml > > > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev- > > > decoder.yaml > > > index bf8082d87ac0..74e1d88d3056 100644 > > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > > subdev-decoder.yaml > > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > > subdev-decoder.yaml > > > @@ -76,6 +76,7 @@ properties: > > > - mediatek,mt8186-vcodec-dec > > > - mediatek,mt8188-vcodec-dec > > > - mediatek,mt8195-vcodec-dec > > > + - mediatek,mt8196-vcodec-dec > > > =20 > > > reg: > > > minItems: 1 > > > --=20 > > > 2.45.2 > > >=20 --JdEKl3bSogEo/Lcd Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaka0GAAKCRB4tDGHoIJi 0gcwAQCtMtUoW/cbg4OpVaaf+u+0oq30lr9mkXMb60IDpSgRaQEAsdk2ey0KDekc nYS63SVumLqJUdoy4hxVqlFifZehUQo= =16wN -----END PGP SIGNATURE----- --JdEKl3bSogEo/Lcd--