From: Jonathan Cameron <jic23@kernel.org>
To: "Erim, Salih" <salih.erim@amd.com>
Cc: andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
conall.ogriofa@amd.com, michal.simek@amd.com, linux@roeck-us.net,
erimsalih@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v11 3/5] iio: adc: versal-sysmon: add I2C driver
Date: Thu, 2 Jul 2026 01:06:50 +0100 [thread overview]
Message-ID: <20260702010650.50e5ee4a@jic23-huawei> (raw)
In-Reply-To: <bcbd202e-7d43-4f59-9ff3-59b564e4a3f4@amd.com>
On Tue, 23 Jun 2026 12:33:33 +0100
"Erim, Salih" <salih.erim@amd.com> wrote:
> Addressing Sashiko findings on this patch:
>
> - [High] Non-atomic I2C read transaction releases the bus lock,
> making it vulnerable to bus interleaving.
>
> The SysMon I2C interface is typically on a dedicated bus with
> no other devices. The current implementation works correctly
> in all tested configurations. Switching to i2c_transfer() with
> Repeated Start would match the TRM protocol diagram but would
> require hardware testing on a board with I2C-accessible SysMon.
> No change for now.
>
To me this smells like a nice to have. However, I agree with your
comment that it almost certainly doesn't matter. Maybe one to add
to the backlog for next time any new features are being added to the driver.
next prev parent reply other threads:[~2026-07-02 0:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 1:40 [PATCH v11 0/5] iio: adc: add Versal SysMon driver Salih Erim
2026-06-23 1:40 ` [PATCH v11 1/5] dt-bindings: iio: adc: add xlnx,versal-sysmon binding Salih Erim
2026-06-23 1:40 ` [PATCH v11 2/5] iio: adc: add Versal SysMon driver Salih Erim
2026-06-23 1:40 ` [PATCH v11 3/5] iio: adc: versal-sysmon: add I2C driver Salih Erim
2026-06-23 2:03 ` sashiko-bot
2026-06-23 11:33 ` Erim, Salih
2026-07-02 0:06 ` Jonathan Cameron [this message]
2026-06-23 1:40 ` [PATCH v11 4/5] iio: adc: versal-sysmon: add threshold event support Salih Erim
2026-06-23 2:15 ` sashiko-bot
2026-06-23 11:36 ` Erim, Salih
2026-06-23 1:40 ` [PATCH v11 5/5] iio: adc: versal-sysmon: add oversampling support Salih Erim
2026-06-23 2:21 ` sashiko-bot
2026-06-23 11:37 ` Erim, Salih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702010650.50e5ee4a@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conall.ogriofa@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=erimsalih@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=salih.erim@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox