Re: [PATCH 3/3] riscv: dts: spacemit: k3: Add UFS support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Undeclared clock macro CLK_APMU_UFS_REFCLK will break device tree compilation.
- [Low] The `ufshc@c0e00000` node is placed out of order inside the `soc` bus node.
- [Low] Missing commas in the freq-table-hz array will cause dtbs_check schema validation to fail.
--

commit 065548f4228bb50038a171b531eac2901642579a
Author: Yixun Lan <dlan@kernel.org>

riscv: dts: spacemit: k3: Add UFS support

This commit adds UFS Host Controller support for the SpacemiT K3 SoC. It also
enables it on both the Pico-ITX and CoM260-IFX boards.

[ ... ]

> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index 19fc9b49668ed..6c0b0598d5c86 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> @@ -1186,5 +1186,18 @@ maplic: interrupt-controller@f1800000 {
>  			riscv,num-sources = <512>;
>  			status = "reserved";
>  		};
> +
> +		ufshc: ufshc@c0e00000 {

[Severity: Low]
Is this node placed in the correct order? The ufshc@c0e00000 node is appended
at the end of the file, after interrupt-controller@f1800000. Should child nodes
of a bus be sorted in ascending order by their unit-address?

> +			compatible = "spacemit,k3-ufshc";
> +			reg = <0x0 0xc0e00000 0x0 0x40000>;
> +			clocks = <&syscon_apmu CLK_APMU_UFS_ACLK>,
> +				 <&syscon_apmu CLK_APMU_UFS_REFCLK>;

[Severity: Low]
Does this undeclared clock macro CLK_APMU_UFS_REFCLK cause the device tree
compilation (make dtbs) to fail with a syntax error?

> +			clock-names = "aclk", "ref_clk";
> +			resets = <&syscon_apmu RESET_APMU_UFS_ACLK>;
> +			interrupts = <135 IRQ_TYPE_LEVEL_HIGH>;
> +			freq-table-hz = <491520000 491520000 19200000 19200000>;

[Severity: Low]
Will the missing commas here cause dtbs_check schema validation to fail?

The ufs-common.yaml schema requires freq-table-hz to be a list of arrays
(min/max frequency tuples per clock). When written as a flat array without
separating commas, dtc processes it into a single array which the YAML schema
validator may reject since it expects exact 2-element inner tuples.

> +			lanes-per-direction = <2>;
> +			status = "disabled";
> +		};
>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org?part=3