Re: [PATCH v4 1/2] dt-bindings: media: i2c: Add os02g10 sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing hardware-specific constraints for `data-lanes` and `link-frequencies`, and missing `data-lanes` in the required list.
- [Low] Contradictory voltage level for `dvdd-supply` and a typo in a phandle name in the example.
--

commit ce94f55aec46b60fcbb8306168231259fed7b004
Author: Elgin Perumbilly <elgin.perumbilly@siliconsignals.io>

dt-bindings: media: i2c: Add os02g10 sensor
    
This commit adds the Device Tree bindings for the OmniVision OS02G10 image
sensor. The sensor outputs RAW10 format data and supports a 2-lane MIPI
interface.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,os02g10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,os02g10.yaml
> new file mode 100644
> index 0000000000000..72c6beff3625e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,os02g10.yaml
> @@ -0,0 +1,94 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---

[ ... ]

> +  dovdd-supply:
> +    description: I/O Domain Power Supply (1.8v)
> +
> +  dvdd-supply:
> +    description: Digital core Power Supply (1.5v)
> +
> +  reset-gpios:

[ ... ]

> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        required:
> +          - link-frequencies

[Severity: Medium]
Should data-lanes be included in this required list?

Since the sensor specifically supports a 2-lane MIPI interface, would it also
make sense to add constraints for data-lanes (e.g., maxItems: 2) and
link-frequencies (e.g., maxItems: 1) here so that unsupported configurations
will fail schema validation?

> +
> +    required:
> +      - endpoint

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera-sensor@3c {
> +            compatible = "ovti,os02g10";
> +            reg = <0x3c>;
> +            clocks = <&os02g10_clk>;
> +            reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
> +
> +            avdd-supply = <&os02g10_avdd_2v8>;
> +            dvdd-supply = <&os02g10_dvdd_1v2>;
> +            dovdd-supply = <&os2gb10_dovdd_1v8>;

[Severity: Low]
Does the digital core power supply require 1.5V or 1.2V? The property
description for dvdd-supply above states 1.5V, but the example phandle name
here implies 1.2V.

Also, this isn't a bug, but there appears to be a typo in the dovdd-supply
phandle name (os2gb10 instead of os02g10).

> +
> +            port {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702072502.7907-1-elgin.perumbilly@siliconsignals.io?part=1