Re: [PATCH v7 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Provider capability properties (`#clock-cells`, `#reset-cells`) are missing from the `required` list.
- [Medium] Enforcing the newly introduced regulator supplies as strictly `required` breaks DT ABI backward compatibility for existing nodes.
--

commit 5e430d824fb02882cee1134048f0cc37d37b28cc
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move glymur TCSR to own binding

This patch extracts the Glymur TCSR clock controller into a dedicated
binding file. It documents the vdda supply properties required for the
QREF block, as its control interface resides in the TCSR node.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> new file mode 100644
> index 0000000000000..ec89feff89e4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> @@ -0,0 +1,126 @@
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,glymur-tcsr
> +    then:
> +      required:
> +        - vdda-qrefrpt0-0p9-supply
> +        - vdda-qrefrpt1-0p9-supply

[Severity: Medium]
Does enforcing these newly added regulator supplies as strictly required 
break backward compatibility with existing device trees?

Older DTBs that already use the qcom,glymur-tcsr compatible string might 
not have these vdda-*-supply properties, which would cause them to fail 
schema validation during dtbs_check. Device tree bindings act as a stable 
ABI, and converting non-existent properties into strictly required 
properties breaks this ABI.

Could these be made optional or gracefully handled to preserve backward 
compatibility for older device trees?

[ ... ]
> +        - vdda-refgen4-0p9-supply
> +        - vdda-refgen4-1p2-supply
> +
> +required:
> +  - compatible
> +  - clocks
> +
> +additionalProperties: false

[Severity: Medium]
Should #clock-cells and #reset-cells be included in this required block?

Since this binding documents a clock and reset provider, omitting the cell 
properties from the required list might allow incomplete device tree nodes 
to silently pass schema validation. This can lead to runtime failures when 
dependent drivers attempt to use the undocumented provider capabilities.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-tcsr_qref_0702-v7-0-776f2811b7af@oss.qualcomm.com?part=1