From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B0394189B2; Thu, 2 Jul 2026 08:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782980635; cv=none; b=VlR9WCXlUIiM7YBLWpXyJ+1ebEJ90qPjScUBKlNTAdmoInNRiQSZR8JcSIHqj07010PWfNGwFRl7a2cOMpmX8W5iIwv02ubXantuA9mwsy0wZCDtxp6MtnZlXNUA5BHnZ0Pc8GOFqmCaanzH6nyiasFw13vEyJTr6RnK04mq65A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782980635; c=relaxed/simple; bh=7bYHsUXG+FaYYZNg1wJs3IPn7MVk2vRmY/KLPB8trcY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=HroH4A1G2YlFEmRo9nJQ2FrmWATtvF7SZvtPXSfArHMztGBmNHA2DUjCtGbhzKCQOGmSyjKd2SkqPMCvjuypK6xIgx5J9xpUwzR3ALP2K3Nk6IE2XmFiyCOXx6ucd/LbeukRhb4VWixdBjXYnwsULdnRK+2nhFdbDcXmqJN6ahk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PiF4RbYa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PiF4RbYa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 078A11F000E9; Thu, 2 Jul 2026 08:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782980634; bh=7bYHsUXG+FaYYZNg1wJs3IPn7MVk2vRmY/KLPB8trcY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PiF4RbYaDBoEA9LKU5NDa4mSGYKQw8TAf4bBZhdoSjLDLf0cUcyjN0jtquAOpARGQ D38YCShhtVQnm20HfBtsfUg/WvoCKFaZMVNb+LMG2ybt6T8H9vMe85iW5mc2AFa/i6 cgX0WYlFkXDHmADed0UJlByxzEdduUPirsYcGq9vY8hzLEbXU+cBuOy23dlnlivrem hm7Dd9FyYhyfLazp2hJmnxgjvgu5ME2RgsBACBhC8zgZqeKIPaOsV1+Pj28eYzvZ65 pEU7Oi6+qq0nZHwXklZdanPZLYju4Srp9Zli/EaPIA+hNZiKsjKFiQv7nXJdl9ktWt BpYck+SrXrARg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 7/8] clk: sunxi-ng: sun6i-rtc: split main oscillator div and gate. Reply-To: sashiko-reviews@lists.linux.dev To: "Jerome Brunet" Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, linux-sunxi@lists.linux.dev, "Alexandre Belloni" , conor+dt@kernel.org In-Reply-To: <20260702-a733-rtc-v3-7-eb2580374de6@baylibre.com> References: <20260702-a733-rtc-v3-0-eb2580374de6@baylibre.com> <20260702-a733-rtc-v3-7-eb2580374de6@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 02 Jul 2026 08:23:53 +0000 Message-Id: <20260702082354.078A11F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > On the a733 the "osc24M-32k" clock has the same gate bits as the previous= ly > supported SoC but a different divider implementation. >=20 > Instead of a fixed 750 divider, the divider is selected based on the > rate of the oscillator. It can be seen as a simple read-only divider. >=20 > To easily replace the divider part depending the SoC, split the divider > and gate into two separate clock entities. >=20 > Signed-off-by: Jerome Brunet Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260702-a733-rtc-v= 3-0-eb2580374de6@baylibre.com?part=3D7