From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E663547ECC8; Thu, 2 Jul 2026 09:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782985726; cv=none; b=VBq2kJqsALre//5in8WSBHUtoVzA7wAS4KfOW6qa/sWh/gX2YYMUQTRX/Ruk3mEN7+shAY0qDiu9KPUzpqcHP6Is4z1TxvO58716JjuUkq1/8L8FLjTnB1OwioCpvw59AHgeWsCfGIdGJGkK41gXw6MH8JurtIyXAz2zAuoxmHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782985726; c=relaxed/simple; bh=Eyu11J5qv2ZHi+Qi9Vyi5LEotpm2dk7vSRiNNvts5yk=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=J5TAZ65+4tIOGdjkhwEO6QaG5REmWglYvUclTIESqpRKxzf8aTCklAQLaYxfwsfgSvzMxSb4gHbVomXjo9xuBg+FTm+9HLMhOh1Bp1sSbo2CXoWG5hRc76yh/deYoiV8LPzOMIR0e+FRBUuuQ1H/RDh1uUBsANs4kpl8a6s20x0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZNjt3TCy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZNjt3TCy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB5BA1F01561; Thu, 2 Jul 2026 09:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782985723; bh=25uRpcrhlekZgFGBJk/vF4cL8fcos6REBCogQ2xzQPo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ZNjt3TCyeddP9Lm0ZCnLLO9cagutMOPkg42FqKWCmVOjRBRGAr7cMS/ez2Eg7RsrQ N/uXDxtx/bytSVkpzhGqclleM0kuAyfUobcMVoSZxaowEEFgVGnkSvBSqp8fzZ3oCj 6K7L7kfhaatIoHc6l+4yfhWhAxaSqax8352DClpwViBCC6zfGGYexj/ynYjRJCj8ky D77uPEDARnSbrcdzC+dl+WP5zTlJOnKpM238KvkblGY2BWWIdPICbudm3/Dx7pj9lU tElaqWy1P+JwFMTNHcY/WRqz5IOwSFWV9iPyoujyfUNzvISuUmVcaKqYtW4MCnr675 YDkIXIIhDorXg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/18] arm64: dts: ti: k3-j722s-evm: Add overlay for fusion application daughter board Reply-To: sashiko-reviews@lists.linux.dev To: "Yemike Abhilash Chandra" Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, robh@kernel.org, imx@lists.linux.dev In-Reply-To: <20260702093123.1048575-11-y-abhilashchandra@ti.com> References: <20260702093123.1048575-1-y-abhilashchandra@ti.com> <20260702093123.1048575-11-y-abhilashchandra@ti.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 02 Jul 2026 09:48:42 +0000 Message-Id: <20260702094842.BB5BA1F01561@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [Low] Incorrect EVM name in the file header comment. - [Low] Unused header inclusion. - [Low] Inconsistent formatting in port declarations. -- commit 7986b08cfb6e71a222dd7aeeb1377324b1869253 Author: Vaishnav Achath arm64: dts: ti: k3-j722s-evm: Add overlay for fusion application daughter b= oard This commit adds a device tree overlay for the Fusion application daughter board on the TI J722S EVM. It configures two DS90UB960 deserializers to aggregate input from up to 8x FPDLink-III sensors over the CSI RX ports. > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-fusion.dtso b/ar= ch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-fusion.dtso > new file mode 100644 > index 0000000000000..cbad2409a9c18 > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-fusion.dtso > @@ -0,0 +1,196 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * DT Overlay for Fusion (FPD-Link III) board on J721E EVM [Severity: Low] This isn't a bug, but should this read J722S EVM instead of J721E EVM to match the target board mentioned in the commit message and file name? > + * https://svtronics.com/portfolio/evm577pfusion-v1-0-fusion/ > + * > + * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/ > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include [Severity: Low] This isn't a bug, but is this dt-bindings/gpio/gpio.h inclusion necessary? It appears no GPIO-related bindings or constants are actually used in this overlay. [ ... ] > + ds90ub960_0_ports: ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0{ > + reg=3D <0>; > + status =3D "disabled"; > + }; [Severity: Low] This isn't a bug, but does this spacing follow the standard device tree formatting conventions? There appear to be missing spaces before the opening brace and after the equals sign here, such as port@0 { instead of port@0{,= =20 and reg =3D <0>; instead of reg=3D <0>;. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260702093123.1048= 575-1-y-abhilashchandra@ti.com?part=3D10