Re: [PATCH v3] arm64: dts: qcom: sm8650-ayaneo-pocket-s2: add display nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `mdp_vsync_active` and `mdp_vsync_suspend` pinctrl states are defined to configure hardware VSYNC, but they are never applied to any device node.
- [Low] The patch introduces devicetree nodes with undocumented `compatible` strings (`sgmicro,sgm3804`, `silergy,sy7758`, `ayaneo,wt0630-2k`, `renesas,r63419`) that lack in-tree bindings and drivers.
--

commit 64734ca20f06a3d7e88667241a73106d33fde6b6
Author: KancyJoe <kancy2333@outlook.com>

arm64: dts: qcom: sm8650-ayaneo-pocket-s2: add display nodes

Add nodes for the dual DSI panel, the SGM3804 regulator, the
SY7758 backlight controller, the touch controller, and enable
the GPU to enable full display support.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts b/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
> index 0dc994f4e48d9..56818fc9edbfc 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts

[ ... ]

> @@ -1053,6 +1102,51 @@ redriver_ss_in: endpoint {
>  	};
>  };
>  
> +&i2c9 {
> +	status = "okay";
> +
> +	/* Screen power */
> +	regulator@3e {
> +		compatible = "sgmicro,sgm3804";

[Severity: Low]
Are the compatible strings sgmicro,sgm3804, silergy,sy7758, ayaneo,wt0630-2k,
and renesas,r63419 missing bindings? It looks like dtbs_check validation could
fail due to missing bindings, and the corresponding devices might not
instantiate if no drivers exist in the tree.

> +		reg = <0x3e>;
> +
> +		pinctrl-0 = <&sgm3804_default>;

[ ... ]

> +	panel@0 {
> +		status = "okay";
> +		compatible = "ayaneo,wt0630-2k", "renesas,r63419";
> +		reg = <0>;
> +
> +		pinctrl-0 = <&disp0_reset_n_active>;
> +		pinctrl-1 = <&disp0_reset_n_suspend>;

[Severity: Medium]
Should mdp_vsync_active and mdp_vsync_suspend be included in pinctrl-0 and
pinctrl-1 alongside the reset states?

The mdp_vsync_active and mdp_vsync_suspend states are defined below to
configure hardware VSYNC, but they do not seem to be applied to any device
node. This might leave the VSYNC pin unmuxed, disconnecting the hardware
Tearing Effect signal and causing screen tearing on the display.

> +		pinctrl-names = "default", "sleep";
> +
> +		vddio-supply = <&vreg_l12b_1p8>;

[ ... ]

> +	mdp_vsync_active: mdp-vsync-active-state {
> +		pins = "gpio86";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};
> +
> +	mdp_vsync_suspend: mdp-vsync-suspend-state {
> +		pins = "gpio86";
> +		function = "mdp_vsync";
> +		drive-strength = <2>;
> +		bias-pull-down;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-topic-sm8650-ayaneo-pocket-s2-display-dt-v3-1-e6de68d33f9b@linaro.org?part=1