Re: [PATCH v6 6/7] dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#thermal-sensor-cells` property is missing from the required list for the new `airoha,an7583-chip-scu` variant.
--

commit a9f67eec355a32d0b9aed09bea5f0bd79ecbc7c5
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC

This commit documents support for the Airoha AN7583 chip-scu node. It is
similar to the EN7581 SoC but adds support for a thermal sensor.

> diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> index 67c449d804c22..cc564dc7b414d 100644
> --- a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> +++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
[ ... ]
> @@ -19,15 +19,29 @@ properties:
>      items:
>        - enum:
>            - airoha,en7581-chip-scu
> +          - airoha,an7583-chip-scu
>        - const: syscon
>  
>    reg:
>      maxItems: 1
>  
> +  '#thermal-sensor-cells':
> +    const: 0
> +
>  required:
>    - compatible
>    - reg
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: airoha,en7581-chip-scu
> +
> +then:
> +  properties:
> +    '#thermal-sensor-cells': false
> +

[Severity: Medium]
Since the AN7583 variant adds thermal sensor capabilities, shouldn't 
#thermal-sensor-cells be conditionally added to the required properties list 
for airoha,an7583-chip-scu?

Without enforcing this via an else block or an additional conditional, device 
tree nodes for the new AN7583 variant might silently pass schema validation 
even if they omit the #thermal-sensor-cells property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702094846.17325-1-ansuelsmth@gmail.com?part=6