Re: [PATCH RFC v2 1/9] dt-bindings: clock: renesas,cpg-mssr: Support RZ/T2H system controllers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `ranges` property is not disabled for older SoCs in the conditional `else` block, breaking schema strictness.
--

commit 8928eeb31cda815a1d3749583aab3a96187dea08
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

dt-bindings: clock: renesas,cpg-mssr: Support RZ/T2H system controllers

This commit updates the CPG/MSSR binding to support child system
controllers for RZ/T2H and RZ/N2H SoCs. It adds #address-cells,
#size-cells, and ranges properties, and restricts them to these
specific SoCs to prevent affecting existing bindings.

> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.yaml
[ ... ]
> @@ -126,6 +161,10 @@ allOf:
>        properties:
>          reg:
>            maxItems: 1
> +        '#address-cells': false
> +        '#size-cells': false

[Severity: Medium]
Should ranges also be set to false here?

Since ranges was added globally in the properties block, omitting
ranges: false in this else block allows older SoCs to erroneously
include a ranges property and still silently pass schema validation.
Adding it alongside #address-cells and #size-cells would fully restrict
the newly introduced properties for other Renesas SoCs.

> +      patternProperties:
> +        "^system-controller@[0-9a-f]+$": false
>    - if:
>        not:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702123112.161160-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=1