From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8CC3955EF for ; Thu, 2 Jul 2026 18:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783015568; cv=none; b=bWSAzLBcYMsIgCDmcsC3ZD7XtWiPykDMpU9CoHI0giNOEEOJ2QIT0Wy2omspTFIE4Ju2kOAFLuUzjmsj0Fw0iZKn1CUJs0qf1qmJnd6QC3LpM1K71s6wkS2ymCzOBwCre5HobRRUZZ1y36HL6f5WgGzlRiyAX9WI+X/YY5n3zQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783015568; c=relaxed/simple; bh=f2inAP+pXVGh4E+sARO3ce21KB69lzS3/RyR/bAuLvQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=oFEjpdBs+3ZvWkz8LJ3qAFFpNjKBLiVSZ0oyhPiHKkwW1049ipDE7x5Nb9npLqDpZvt26GykYtE0YoU3O3DT29dKoeFTbzBD+S+RiGIgHS26Z/LD26WwFJrJy04JkB7Qr7QtjhfIHA++RosXv3Kkaqh6V+qoGomp/f3omDxtUGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fPWu1mJ0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fPWu1mJ0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D6C11F00A3A; Thu, 2 Jul 2026 18:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783015567; bh=kaFKZspe1pBMSoPKQPZ4+bwKP343ujonqSJ3tPKVkvE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fPWu1mJ06mQBFCZONfDIZDLvcFfk30m2EXs7pxe2/dXJSl1qRCCLyr9oNcLcgPjcB 8Aypzwq7iAtfLd3QT2A6VnV+8ZSKnV/57yfTSFJMhfxic60WS9LBEEP+jCqCHN4iz4 7sVRSw/dahOrdGboH6vlY5iYg/pD2E1T+iyOmIzxVF4hb6x4AwBN23p27HJNMf6tBR 2oF/eENS3hRY3Kc0tEo4AMOI6vZ44HuecbJnAEPI5m7gVHN2AMNYxFjtuHOkkm3viu Qk42ht3zdkNaJa5ru59zR32lEbh0pealOnDUgsZzR5hmzQ5ttHJc0Q2JQLJigBDKaT ZG9W7X9WGp/Dg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 07/15] clk: mediatek: Add MT8189 topckgen clock support Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260701-mt8189-clocks-system-base-v1-7-2b048feea50a@collabora.com> References: <20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com> <20260701-mt8189-clocks-system-base-v1-7-2b048feea50a@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 02 Jul 2026 18:06:07 +0000 Message-Id: <20260702180607.8D6C11F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Missing MODULE_DEVICE_TABLE(of, ...) macro prevents module autol= oading. -- commit ad61575ea6a112e8fdb28af2de8ae432cbe5778c Author: Louis-Alexis Eyraud clk: mediatek: Add MT8189 topckgen clock support Add support for the MT8189 topckgen clock controller, which provides muxes and dividers for clock selection in other IP blocks. > diff --git a/drivers/clk/mediatek/clk-mt8189-topckgen.c b/drivers/clk/med= iatek/clk-mt8189-topckgen.c > new file mode 100644 > index 0000000000000..62d292f5b8b87 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8189-topckgen.c [ ... ] > +static const struct of_device_id of_match_clk_mt8189_topck[] =3D { > + { .compatible =3D "mediatek,mt8189-topckgen", .data =3D &topck_desc }, > + { /* sentinel */ } > +}; [Severity: Medium] Will this module automatically load if configured as a loadable module (=3D= m)? Without the MODULE_DEVICE_TABLE(of, ...) macro, it appears udev won't=20 be able to automatically load the driver based on the device tree compatible string alias. This could leave downstream IP blocks that depend on the topckgen clocks without clock support, potentially causing functional or boot failures. > + > +static struct platform_driver clk_mt8189_topck_drv =3D { > + .probe =3D mtk_clk_simple_probe, > + .remove =3D mtk_clk_simple_remove, > + .driver =3D { > + .name =3D "clk-mt8189-topck", > + .of_match_table =3D of_match_clk_mt8189_topck, > + }, > +}; [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260701-mt8189-clo= cks-system-base-v1-0-2b048feea50a@collabora.com?part=3D7