Re: [PATCH v4 3/3] arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Contradictory IRQ polarity and internal pull-down resistor for the WiFi host-wake interrupt.
--

commit 5e0547ff442a7edaa2500fa690169e0535d25791
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

This commit introduces the devicetree for the Graperain G3568 v2, an
RK3568-based development board. It configures the hardware description for
various components including ethernet, wireless radio, and peripherals.

Link: https://image.chukouplus.com/upload/C_153/product_file/20211022/6daddec9e400458816dd4c57ba807fc3.pdf
Link: https://blog.gov.cooking/archives/research-graperain-g3568-v2-and-flash.html

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts b/arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts
> new file mode 100644
> index 0000000000000..5fc043b352042
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts

[ ... ]

> +	wifi-irq {
> +		wifi_host_wake_irq: wifi-host-wake-irq {
> +			rockchip,pins = <3 RK_PD4 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};
> +	};
> +};

[ ... ]

> +	wifi@1 {
> +		compatible = "brcm,bcm4356-fmac", "brcm,bcm4329-fmac";
> +		reg = <1>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <RK_PD4 IRQ_TYPE_LEVEL_LOW>;

[Severity: High]
Will this combination of an active-low level-triggered interrupt and a
pull-down resistor cause an interrupt storm?

If the WiFi module enters a sleep state and leaves the pin floating, the
pull-down configured in wifi_host_wake_irq will drive the pin low. Because
the interrupt is configured as IRQ_TYPE_LEVEL_LOW, won't the kernel
continuously fire the interrupt handler?

> +		interrupt-names = "host-wake";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&wifi_host_wake_irq>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702193538.2195973-1-coiaprant@gmail.com?part=3