From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chris Hall" <c-hall@ti.com>, "Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Nguyen Minh Tien" <zizuzacker@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/8] iio: adc: ti-ads112c14: add measurement channel support
Date: Thu, 2 Jul 2026 20:10:49 +0100 [thread overview]
Message-ID: <20260702201049.164d939f@jic23-huawei> (raw)
In-Reply-To: <544fbdef-268d-49cc-ae9e-b18907d9382b@baylibre.com>
On Thu, 2 Jul 2026 09:18:41 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 7/2/26 4:18 AM, Andy Shevchenko wrote:
> > On Wed, Jul 01, 2026 at 09:20:19PM +0100, Jonathan Cameron wrote:
> >> On Thu, 25 Jun 2026 16:55:10 -0500
> >> "David Lechner (TI)" <dlechner@baylibre.com> wrote:
> >
> > ...
> >
> >>> + device_for_each_named_child_node_scoped(dev, child, "channel") {
> >>> + struct ads112c14_measurement *measurement = &data->measurements[i];
> >>> + struct iio_chan_spec *spec = &channels[i];
> >
> >>> + if (!fwnode_device_is_available(child))
> >>> + continue;
> >
> > Also drop this dup check.
> >
>
> How is this duplicate? device_for_each_named_child_node_scoped()
> doesn't check this.
It is convoluted to show but it does (now)...
Ultimately for dt case it calls
of_get_next_status_child(node, prev, __of_device_is_available);
IIRC that didn't used to the be the case and we had iterators
for available and not available both for DT they always meant
available and more recently it got cleaned up as the number
of places that need to pass non available nodes is tiny!
Jonathan
prev parent reply other threads:[~2026-07-02 19:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 21:55 [PATCH v2 0/8] iio: adc: new ti-ads112c14 driver David Lechner
2026-06-25 21:55 ` [PATCH v2 1/8] dt-bindings: iio: adc: Add reference-sources property David Lechner
2026-06-26 16:12 ` Conor Dooley
2026-06-29 6:47 ` Kurt Borja
2026-06-25 21:55 ` [PATCH v2 2/8] dt-bindings: iio: adc: Add excitation current sources properties David Lechner
2026-06-26 16:10 ` Conor Dooley
2026-07-01 19:39 ` Jonathan Cameron
2026-07-01 22:07 ` David Lechner
2026-06-25 21:55 ` [PATCH v2 3/8] dt-bindings: iio: adc: Add burn-out current properties David Lechner
2026-06-26 16:12 ` Conor Dooley
2026-06-25 21:55 ` [PATCH v2 4/8] dt-bindings: iio: adc: add input-channel-rotation property David Lechner (TI)
2026-06-26 16:14 ` Conor Dooley
2026-06-26 18:27 ` David Lechner
2026-07-01 19:41 ` Jonathan Cameron
2026-07-02 18:58 ` Conor Dooley
2026-07-02 19:30 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 5/8] dt-bindings: iio: adc: add ti,ads122c14 David Lechner (TI)
2026-06-25 22:12 ` sashiko-bot
2026-06-26 16:18 ` Conor Dooley
2026-06-26 18:35 ` David Lechner
2026-06-27 14:03 ` Conor Dooley
2026-07-01 19:50 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 6/8] iio: adc: add ti-ads112c14 driver David Lechner (TI)
2026-06-25 22:07 ` sashiko-bot
2026-07-01 19:59 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 7/8] iio: adc: ti-ads112c14: implement gain on internal short SYS_MON channel David Lechner (TI)
2026-06-25 22:08 ` sashiko-bot
2026-07-01 20:02 ` Jonathan Cameron
2026-06-25 21:55 ` [PATCH v2 8/8] iio: adc: ti-ads112c14: add measurement channel support David Lechner (TI)
2026-06-25 22:11 ` sashiko-bot
2026-07-01 20:20 ` Jonathan Cameron
2026-07-02 9:18 ` Andy Shevchenko
2026-07-02 14:18 ` David Lechner
2026-07-02 19:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702201049.164d939f@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
--cc=robh@kernel.org \
--cc=zizuzacker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox