Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Kurt Borja" <kuurtb@gmail.com>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/3] dt-bindings: iio: adc: Add reference-source property
Date: Thu, 2 Jul 2026 20:20:02 +0100	[thread overview]
Message-ID: <20260702202002.79c1be1b@jic23-huawei> (raw)
In-Reply-To: <baeb24dd-214f-4dc8-a300-22b932c4b4ae@baylibre.com>

On Mon, 22 Jun 2026 14:40:10 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 6/22/26 2:30 PM, Kurt Borja wrote:
> > Some ADCs have configurable voltage reference sources for each channel.
> > 
> > Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adc.yaml | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > index b9bc02b5b07a4c7..fdad6b8276c934c 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> > @@ -73,6 +73,19 @@ properties:
> >        device design and can interact with other characteristics such as
> >        settling time.
> >  
> > +  reference-source:  
> 
> Since this is an array, the name should be `reference-sources`.
> 
> > +    $ref: /schemas/types.yaml#/definitions/string-array
> > +    maxItems: 2
> > +    minItems: 1  
> 
> Maybe minItems here is OK, but I don't think we should put maxItems here.
> This way, it stays more flexible for other use cases.

I'm curious. What other usecases did you have in mind?

> 
> > +    description:
> > +      Indicates the voltage reference source or sources for this channel. Some
> > +      ADCs usually allow choosing between internal reference sources or a pair
> > +      of external pins.
> > +
> > +      If a single value is provided, it represents a single voltage reference
> > +      source. If two values are provided, the first one corresponds to the
> > +      positive source and the second to the negative source.
> > +
> >  anyOf:
> >    - oneOf:
> >        - required:
> >   
> 


  reply	other threads:[~2026-07-02 19:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 19:30 [PATCH RFC v2 0/3] dt-bindings: iio: adc: Add reference, excitation and burn-out properties Kurt Borja
2026-06-22 19:30 ` [PATCH RFC v2 1/3] dt-bindings: iio: adc: Add reference-source property Kurt Borja
2026-06-22 19:40   ` David Lechner
2026-07-02 19:20     ` Jonathan Cameron [this message]
2026-07-02 19:35       ` David Lechner
2026-06-22 19:30 ` [PATCH RFC v2 2/3] dt-bindings: iio: adc: Add excitation current sources properties Kurt Borja
2026-06-22 19:42   ` David Lechner
2026-06-22 19:30 ` [PATCH RFC v2 3/3] dt-bindings: iio: adc: Add burn-out current properties Kurt Borja
2026-06-22 19:44   ` David Lechner
2026-06-22 19:38 ` [PATCH RFC v2 0/3] dt-bindings: iio: adc: Add reference, excitation and burn-out properties David Lechner
2026-06-22 19:58   ` Kurt Borja
2026-06-22 20:01     ` David Lechner
2026-06-22 20:05       ` Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702202002.79c1be1b@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuurtb@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox