From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7151A33C518 for ; Thu, 2 Jul 2026 20:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783025270; cv=none; b=eoR25OXIL582cQCW1BlKnmXQDYadPAGJrNMZzUUBX8pfNkOW8J8hkZyPqFk94ZNRiEhLuEFjyPgw9JTwkwSst1zWGn57u50Q17RsR0Ps2oRiwPy3cjI4B6+QqP6x5kIU+l3nauMfSOdvgaEOwtAj+yUSbIfmaX1eR1zeogqvq4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783025270; c=relaxed/simple; bh=WbLGaJ6juecABtydjYi/ipJNGyo8ZH3uJlUBoIQXCMI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=td/hx3Rol+KX4+2OYXjsaaVofW+2sidtj8rrjGB8eUS5A/sT7kkyX6R1dAZ6fW9VrUNpszJRN0SM9zHyvqbZqjCncgf4yZNP7IdIBYzs7iaJ+PgwwUc73CkmFEM7W3unAw7VvupBV6/840tnGC14wdjlk93l/V+TDHEtaHtkyi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=few/yG9Z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="few/yG9Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C77E61F00A3F; Thu, 2 Jul 2026 20:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783025269; bh=qEIPqSQsO3rUt68zT2qj5SJTjrAil0BehwG/GW7ze7E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=few/yG9Zvu3lcTO/ngZyFITf/oqqUctoQJMH6jkkz7gcGoQQyWKit5qu2N+6UQ0h2 hdirperHnLRsOLbSqqoMYRPLK+ObYD5WUXFoFn9XphWCXkXxXmNp4hUg96XfFUCowP NUttCofrDYtDfxgLlrRs2xZVtzAwhsdf2pm5TGea/YJEDT2lWEx2XQWlJ5zNV4Nz+d IvO2RRWhe7pXrvkOYB4I6QQkiYI0YuuRmCPcRygXiI4+moAmShZWQnNrvTXpLqLKnd iS9suDvbCju6XVhztBlsD8WKyimHbadkoS2tnyaEG27rbpgE7nwGkXQ1ysVQCprhV/ +5IeGhAoXITrg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 12/12] ARM: dts: zte: Declare zx297520v3 CRM device nodes Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260702-zx29clk-v6-12-377b704f80c4@gmail.com> References: <20260702-zx29clk-v6-0-377b704f80c4@gmail.com> <20260702-zx29clk-v6-12-377b704f80c4@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 02 Jul 2026 20:47:48 +0000 Message-Id: <20260702204748.C77E61F00A3F@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The fixed-clock device tree node names do not follow the standard `= clock-` naming pattern, which violates schema constraints. -- commit c7fd353d8042fade42cfb7f95e466ced8cd9112a Author: Stefan D=C3=B6singer ARM: dts: zte: Declare zx297520v3 CRM device nodes This commit adds device tree nodes for the zx297520v3 topcrm, matrixcrm, an= d=20 lspcrm controllers. It replaces the placeholder uartclk with fixed-clocks a= nd wires up the clocks and resets for the UART devices. > diff --git a/arch/arm/boot/dts/zte/zx297520v3.dtsi b/arch/arm/boot/dts/zt= e/zx297520v3.dtsi > index a16c30a164bb9..e3f698e28b498 100644 > --- a/arch/arm/boot/dts/zte/zx297520v3.dtsi > +++ b/arch/arm/boot/dts/zte/zx297520v3.dtsi [ ... ] > @@ -20,13 +22,16 @@ cpu@0 { > }; > }; > =20 > - /* Base bus clock and default for the UART. It will be replaced once a = clock driver has > - * been added. > - */ > - uartclk: uartclk-26000000 { > - #clock-cells =3D <0>; > + osc26m: osc26m { > compatible =3D "fixed-clock"; > clock-frequency =3D <26000000>; > + #clock-cells =3D <0>; > + }; [Severity: Low] Will this node name trigger device tree schema validation warnings? The fixed-clock schema in Documentation/devicetree/bindings/clock/fixed-clo= ck.yaml marks arbitrary node names as deprecated and expects the pattern clock-. Should this be named clock-26000000 instead of osc26m? > + > + osc32k: osc32k { > + compatible =3D "fixed-clock"; > + clock-frequency =3D <32768>; > + #clock-cells =3D <0>; > }; [Severity: Low] Similarly here, should this node be named clock-32768 to conform to the fixed-clock schema? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260702-zx29clk-v6= -0-377b704f80c4@gmail.com?part=3D12