From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F820241C8C; Fri, 3 Jul 2026 02:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783044806; cv=none; b=NmrVyznvTkizmMw0IaJ6g7lTv1f3cF/Uk7poTNwgA4VvnAAckJCrX9gXk2Pm8hKkeHuTQ4pBmCWd8R+E7rGQhmqTs3wS3S5SRnZDzcDga09+8ZX4wQOYW+OoydW7lS3Bq49cr2tYTao7GyZOSwtQlsXlU371hQTFlqxiI6iKrME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783044806; c=relaxed/simple; bh=D+uSMRZNCAJohaZANJi+fcozrpSGbQCo3IAxm7Bs4jY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qi5NncxWc0ZaUGuU72tZMmq6jWX4vcRh4Dt4ELg+WdnGcqtqR0D2/19YtlV3ubvx53aK1xMdKFIdkkUpXbfnoX+057dvBfxtDyT0zRJ10rBIyJj2CWA79KZKjYrWS8rvqGEqKncypZKCWhN5+iDC0aXv3KI+1nSAtGnp2ugf4dE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YbGpht5m; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YbGpht5m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5C631F000E9; Fri, 3 Jul 2026 02:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783044804; bh=B8J5N5ATqqb/sQ5E0nqBZmkphsVSEKcvcog9noD71Hs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YbGpht5mgbRgVduEX9F6SdQ+Wg/iHhHcajnkN6qzJ7bozq9se5YMpiyK1ZBIAJDEn PeeTpfzS47iuDNb8bOh8Cu4+AaxjEXqPGVMwOcQclk4jloF0TBZoGFwh+mu9P/fMvW K3j4kBy86nfjzNfpuyIOKvWrICR6BJqFSPM+8+Suf+9N1czW+xoKM6gNkEPWA0l1Zh ywL6jetBF+xP0X/V3S8Lfm+dRKiaY2uwlzzBBKBR7SUwN97+EiMZFOdPgCOZuniSS+ 9oMZUSlgTODNt47l24r0xSfG2VOvOJvq9uoOjniaqK37hZBR3UjY7GfJQINQ16vOeD snKrc8WyDXUMQ== Date: Fri, 3 Jul 2026 03:13:16 +0100 From: Jonathan Cameron To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH v6 09/16] iio: frequency: ad9910: initial driver implementation Message-ID: <20260703031316.0b4edbcd@jic23-huawei> In-Reply-To: <20260618-ad9910-iio-driver-v6-9-79125ffbe430@analog.com> References: <20260618-ad9910-iio-driver-v6-0-79125ffbe430@analog.com> <20260618-ad9910-iio-driver-v6-9-79125ffbe430@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 18 Jun 2026 14:27:25 +0100 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Add the core AD9910 DDS driver infrastructure with single tone mode > support. This includes SPI register access, profile management via GPIO > pins, PLL/DAC configuration from firmware properties, and single tone > frequency/phase/amplitude control through IIO attributes. > > Signed-off-by: Rodrigo Alencar Hi Rodrigo, just a couple of things that are really really trivial. > diff --git a/drivers/iio/frequency/ad9910.c b/drivers/iio/frequency/ad9910.c > new file mode 100644 > index 000000000000..95b01295e4a0 > --- /dev/null > +++ b/drivers/iio/frequency/ad9910.c > +static int ad9910_parse_fw(struct ad9910_state *st) > +{ > + static const char * const refclk_out_drv0[] = { > + "disabled", "low", "medium", "high", > + }; > + struct device *dev = &st->spi->dev; > + const char *prop; > + u32 tmp; > + int ret; > + > + st->data.pll_enabled = device_property_read_bool(dev, "adi,pll-enable"); > + if (st->data.pll_enabled) { > + tmp = AD9910_ICP_MIN_uA; Perhaps move to an else rather than doing it as set then override? > + prop = "adi,charge-pump-current-microamp"; > + if (device_property_present(dev, prop)) { > + ret = device_property_read_u32(dev, prop, &tmp); > + if (ret) > + return dev_err_probe(dev, ret, "property read: %s\n", prop); > + > + if (tmp < AD9910_ICP_MIN_uA || tmp > AD9910_ICP_MAX_uA) > + return dev_err_probe(dev, -ERANGE, > + "invalid charge pump current %u\n", tmp); > + } > + st->data.pll_charge_pump_current = tmp; > + > + prop = "adi,refclk-out-drive-strength"; > + if (device_property_present(dev, prop)) { > + ret = device_property_match_property_string(dev, prop, > + refclk_out_drv0, > + ARRAY_SIZE(refclk_out_drv0)); > + if (ret < 0) > + return dev_err_probe(dev, ret, "property read: %s\n", prop); > + > + st->data.refclk_out_drv = ret; > + } > + } > + > + return 0; > +}