Re: [PATCH net-next v8 2/9] dt-bindings: net: lan9645x: add LAN9645X switch bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing MDIO bus definition for integrated PHYs in LAN9645X switch binding.
--

(Note: The format of this report is altered due to recitation restrictions. Standard inline diff quoting has been omitted in favor of a free-form summary of the findings.)

commit ab7b03f9ab6454a9469ee1ad3b3543a10a033f6c
Author: Jens Emil Schulz Østergaard <jensemil.schulzostergaard@microchip.com>

dt-bindings: net: lan9645x: add LAN9645X switch bindings

This commit adds device tree binding schemas for the Microchip LAN9645X
multi-port Gigabit AVB/TSN Ethernet switch. It documents the compatible
strings, Ethernet ports, and provides an example configuration.

[Severity: Medium]
The binding description notes that the switch includes five integrated PHYs,
and the provided example references these PHYs using phy-handle properties
such as phy-handle = <&cuphy0>. However, the schema sets
unevaluatedProperties: false at the root level but does not define or include
a reference for an mdio child node.

Will this cause device tree schema validation to reject valid configurations?
If a device tree author correctly adds an mdio child node to represent the
internal bus for these integrated PHYs, the strict property evaluation will
reject it since the mdio property is neither defined in this file nor fully
evaluated by the included dsa.yaml schema. Should an mdio property definition
be added to the root properties list to allow describing the integrated PHYs?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-dsa_lan9645x_switch_driver_base-v8-0-90228d8bba58@microchip.com?part=2