Re: [PATCH v1 1/2] dt-bindings: pinctrl: qcom,milos-lpass-lpi-pinctrl: Add Eliza pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch unintentionally deletes the `items` array from the `reg` property, resulting in the loss of descriptions for the register regions.
--

commit 6846a6f9be06779519b955a26fe5e15eef153d4f
Author: Ravi Hothi <ravi.hothi@oss.qualcomm.com>

dt-bindings: pinctrl: qcom,milos-lpass-lpi-pinctrl: Add Eliza pinctrl

Document compatible for Qualcomm Eliza SoC LPASS LPI pin controller.
Eliza only has a single reg entry instead of two, so the bindings are
updated to reflect the different register layouts.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,milos-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,milos-lpass-lpi-pinctrl.yaml
> index 73e84f1885911..5cb9addb975fa 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,milos-lpass-lpi-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,milos-lpass-lpi-pinctrl.yaml
> @@ -15,12 +15,13 @@ description:
>  
>  properties:
>    compatible:
> -    const: qcom,milos-lpass-lpi-pinctrl
> +    oneOf:
> +      - const: qcom,milos-lpass-lpi-pinctrl
> +      - const: qcom,eliza-lpass-lpi-pinctrl
>  
>    reg:
> -    items:
> -      - description: LPASS LPI TLMM Control and Status registers
> -      - description: LPASS LPI MCC registers
> +    minItems: 1
> +    maxItems: 2

[Severity: Low]
Does this unintentionally remove the descriptions for the register regions?

By deleting the items array under the reg property, the semantic descriptions 
that document the purpose of each register region are lost. 

Would it be better to keep the items list intact and add minItems: 1 alongside
it?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703073029.2588960-1-ravi.hothi@oss.qualcomm.com?part=1