Re: [PATCH 3/3] arm64: dts: qcom: sm7125-samsung: add initial device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `vibrator` node specifies `pinctrl-names = "default";` but lacks the required `pinctrl-0` property to define the pin configuration for the GPIO.
- [Low] The GPIO key node `vol-up` violates the `gpio-keys.yaml` binding schema naming convention.
--

commit 4c3f46af7d91551d5cb47755e411d4869514c5fb
Author: Erikas Bitovtas <xerikasxx@gmail.com>

arm64: dts: qcom: sm7125-samsung: add initial device tree
    
This commit adds the initial device tree for the Samsung Galaxy A52 and A72
devices on the SM7125 platform. It introduces support for basic peripherals
including the framebuffer, GPIO keys, sensors, and regulators.

> diff --git a/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
> new file mode 100644
> index 0000000000000..836dc9b8b1a56
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi

[ ... ]

> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&key_vol_up_default>, <&hall_sensor_default>;
> +
> +		vol-up {

[Severity: Low]
Does this node name violate the gpio-keys.yaml schema?

It looks like dtbs_check expects names following the pattern button-*,
event-*, key-*, or switch-*. Could this be named "key-vol-up" or
"button-vol-up" to avoid validation warnings?

> +			label = "Volume up";
> +			gpios = <&pm6150l_gpios 8 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			debounce-interval = <15>;
> +		};

[ ... ]

> +	vibrator {
> +		compatible = "gpio-vibrator";
> +		enable-gpios = <&tlmm 57 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";

[Severity: Low]
Is there a missing pinctrl-0 property here? 

The pinctrl-names property is defined as "default", but without a
corresponding pinctrl-0, this will trigger a dtbs_check warning and leave
the pin configuration to hardware defaults.

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703-sm7125-samsung-v1-0-3e5f752048c1@gmail.com?part=3