Re: [PATCH v1 09/15] arm64: dts: freescale: imx8mn-var-som: enable FlexSPI interface

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The FlexSPI controller is enabled in the SOM `.dtsi` without a corresponding flash memory child node, preventing flash access and forcing pinmux usage on all carrier boards.
--

commit c172727bc2bd192187db0f36d293f9c48809f6e4
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: freescale: imx8mn-var-som: enable FlexSPI interface

This commit enables the FlexSPI controller on the VAR-SOM-MX8MN and configures
the corresponding pin multiplexing.

> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> index 0abc2d33e7118..259d9f36f8a32 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> @@ -176,6 +176,12 @@ ethphy: ethernet-phy@4 {
>  	};
>  };
>  
> +&flexspi {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_flexspi0>;
> +	status = "okay";
> +};

[Severity: Medium]
Is this missing a child node for the flash device (e.g., flash@0)?

If the QSPI flash is physically located on the SOM, the kernel won't be able
to probe or access it without the child node defined in this tree.

Alternatively, if the flash is intended to be located on the carrier board,
does globally enabling the controller and its pinmux in the SOM's .dtsi
prevent other carrier boards from repurposing these pins if they do not use
FlexSPI?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783067947.git.stefano.r@variscite.com?part=9