From: sashiko-bot@kernel.org
To: "Sarat Addepalli" <sarat.addepalli@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4] arm64: dts: qcom: qcom6490-idp: Add IPA nodes
Date: Fri, 03 Jul 2026 09:06:11 +0000 [thread overview]
Message-ID: <20260703090612.1D2341F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260703085809.2573214-1-sarat.addepalli@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing required properties 'memory-region' and 'qcom,gsi-loader' for the 'ipa' node.
--
commit 3779947d88d9867dec609553d6bb24efded1c1a3
Author: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>
arm64: dts: qcom: qcom6490-idp: Add IPA nodes
This commit adds IPA nodes for the Qualcomm qcm6490 board. It configures
the firmware-name and sets the status to okay, stating that other required
properties are provided by kodiak.dtsi.
Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
[ ... ]
> @@ -619,6 +619,12 @@ &gpu_zap_shader {
> firmware-name = "qcom/qcm6490/a660_zap.mbn";
> };
>
> +&ipa {
> + firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +
> + status = "okay";
> +};
[Severity: Medium]
Will the IPA driver fail to probe here due to missing properties?
The commit message states that the qcom,gsi-loader and memory-region
properties are provided by kodiak.dtsi. However, it appears neither
kodiak.dtsi nor this file actually provides them for the ipa node.
Without qcom,gsi-loader, the driver defaults to self-loading and calls
ipa_firmware_load() during initialization.
Because ipa_firmware_load() requires a memory-region property to map the
firmware memory, lacking it will cause the probe to unconditionally abort.
Should these properties be explicitly added to this node to ensure the
device can successfully initialize?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260703085809.2573214-1-sarat.addepalli@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-03 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 8:58 [PATCH v4] arm64: dts: qcom: qcom6490-idp: Add IPA nodes Sarat Addepalli
2026-07-03 9:06 ` sashiko-bot [this message]
2026-07-03 10:51 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703090612.1D2341F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sarat.addepalli@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox