From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67E4A3C13EF for ; Fri, 3 Jul 2026 13:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783086004; cv=none; b=kRLXOUXHNylgbHlcuPj5BoSN41kR0y/COfU45p30a9UOdtQpPWjBLW5yw9OjpBmH2vEWG7Obsj54Tb7h00pEyist0Bt9Ytrf8zVX817oUtjbLZ8XqDWciXtrIyw9XcNJA6BBsmNvKi5gT6tpAhgOHlcBs745DNTttwJDX+66r5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783086004; c=relaxed/simple; bh=U0FCz6i/tMdzQZ+HXrWlxJ15RZVfGdN4tppqiNMYVV8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=iYxHkHWuF/qV0rgB89R52h/0w4a/nEYYjy1wXAg2axSHSGkfYhSSE1uLlbVrxwUMkg1Fn73iPD55Jn/8e8qbcjhsMRjBmk2utUklGugCq9eQzb6mObHTdfZ8rEEaWhOZX8huSNKC4y/rhm4pwM9UtYAkNSMnMLBrwvLeRWXSgMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HVwZVVj1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HVwZVVj1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5DF51F000E9; Fri, 3 Jul 2026 13:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783086003; bh=v40E2tgbiCyYO6K8eYLvN7TQlgmv6mV+9l/WsUCS1rE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HVwZVVj1mNktLboX+hZpDwliqoQJZHMoX7fKT6OBhzqobxz66oIquO7VrZ0y4Udfg CCogsL4sDFBt6kMsqRfy7O8VkTgs4ErQX9sA4PQwk+f15V0gQ27KsWewwBIvfOP7X9 zFLFVAS4bL+kLU0YJqGLEkyc5WoBw7pJKGqmnUMb0rbAXHsRP7cnItkswfKU9eJ5iJ psUFcuVjU2k8y8il3VEwDTxGn0QX/MI8LH6dbKmeWO3dQ5qGdfgPZDILBI6aVMYhrC lU1qIbd2F0aT+qf6TwUZWI3+u3iGzR7kK7BnPq6DJuL3QRRe+75FLFoInspnLLtRN4 B8cz8wpWAWcdA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 02/12] dt-bindings: soc: fsl: qe: Set #interrupt-cells to 2 to support interrupt type encoding Reply-To: sashiko-reviews@lists.linux.dev To: "Paul Louvel" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260703-qe-pic-gpios-v1-2-6c3e706e27dc@bootlin.com> References: <20260703-qe-pic-gpios-v1-0-6c3e706e27dc@bootlin.com> <20260703-qe-pic-gpios-v1-2-6c3e706e27dc@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 03 Jul 2026 13:40:02 +0000 Message-Id: <20260703134002.C5DF51F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Schema unconditionally changes `#interrupt-cells` from 1 to 2, b= reaking backward compatibility with existing single-cell device trees. -- commit ea9fdfe75d38976a589a83706c16b469e2657dbe Author: Paul Louvel dt-bindings: soc: fsl: qe: Set #interrupt-cells to 2 to support interrupt t= ype encoding This commit updates the #interrupt-cells property constraint in the FSL QE ports interrupt controller binding to support interrupt type encoding. It changes the required value from 1 to 2. > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,q= e-ports-ic.yaml b/Documentation/devicetree/bindings/interrupt-controller/fs= l,qe-ports-ic.yaml > index 2b8e7b9c6d7a4..2b7c6b4f03892 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,qe-ports= -ic.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,qe-ports= -ic.yaml > @@ -23,7 +23,7 @@ properties: > const: 0 > =20 > '#interrupt-cells': > - const: 1 > + const: 2 [Severity: Medium] Does this unconditional change to const: 2 break backward compatibility with existing device trees? Device tree bindings are generally considered ABI. By removing const: 1, schema validation (dtbs_check) will fail for any existing device tree blobs that use #interrupt-cells =3D <1>. Should this be updated to allow both values (e.g., enum: [1, 2]) to safely expand the cell counts while maintaining compatibility with older device trees? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260703-qe-pic-gpi= os-v1-0-6c3e706e27dc@bootlin.com?part=3D2